Update to Plugin Framework #190

t0yv0 · 2023-03-03T23:04:20Z

This is the third attempt to upgrade to Plugin Framework.

Requires: pulumi/pulumi-terraform-bridge#860

Fixes: #149

PreStateUpgradeHook is added to ensure that despite breaking changes upstream and the fact that upstream does not properly upgrade state, the problem #173 does not recur and simple programs with self-signed certs generate update, not replace plans when upgrading the provider.

Upstream crosses a major version boundary and we do not have capacity to completely compensate to make it non-breaking, therefore it's a new major release (v5.x.x.). The PR includes changes to move code to v5 (especially affecting Go).

github-actions · 2023-03-03T23:07:33Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
No new resources/functions.

github-actions · 2023-03-03T23:15:09Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
No new resources/functions.

iwahbe

It looks like schema changes broke one of our tests.

t0yv0 · 2023-03-08T16:22:46Z

Yes that's a breaking change from upstream I don't know how to compensate for, so editing out the examples for now.

github-actions · 2023-03-08T16:25:46Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
No new resources/functions.

github-actions · 2023-03-08T19:28:07Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
No new resources/functions.

github-actions · 2023-03-08T21:48:18Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
No new resources/functions.

github-actions · 2023-03-08T22:15:44Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
No new resources/functions.

github-actions · 2023-03-08T22:25:41Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
No new resources/functions.

github-actions · 2023-03-08T22:37:32Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
No new resources/functions.

t0yv0 · 2023-03-08T22:47:35Z

scripts/new_major_version.go

@@ -0,0 +1,103 @@
+// go run scripts/new_major_version.go -ver v5 -name tls goes part of the way to udpate all Go source references to a


Calling this out. Doesn't really belong here, but I was trying to see if it can automate part of the edits for a major version release via the "gofmt" route. This is the "regex based" alternative to pulumi/ci-mgmt#319

t0yv0 · 2023-03-08T22:51:48Z

examples/self-signed-cert/go/go.mod

 )

+replace github.com/pulumi/pulumi-tls/sdk/v5 => ../../../sdk


Having this replace in makes it compilable before a 5.x release, though I think ProgramTest makes it possible to fix it up in flight.

t0yv0 · 2023-03-08T22:53:17Z

Makefile

@@ -1,18 +1,24 @@
+# NOTE: temporary hand edited to add --version-prefix.


Calling out this temporary edit. VERSION_PREFIX makes CI generate 5.x.x versions before an actual 5.x.x release.

Would it make sense to make the PR to ci-mgmt first to edit major-version here:

https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/providers/tls/config.yaml

And rebase on top of that? Might reduce the size of the diff, maybe obviate some of these changes.

I'd rather follow up with a PR to clean up. I've put the comments in pulumi/ci-mgmt#318 and sounds like we're doing that next iteration - once that's in this dance won't be needed anymore.

t0yv0 · 2023-03-09T02:13:40Z

Dropping the scripts code, taking it to pulumi/upgrade-provider#9

github-actions · 2023-03-09T02:17:35Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
No new resources/functions.

AaronFriel · 2023-03-09T22:36:24Z

Makefile

 VERSION_PATH := $(PROVIDER_PATH)/pkg/version.Version
 TFGEN := pulumi-tfgen-$(PACK)
 PROVIDER := pulumi-resource-$(PACK)
-VERSION := $(shell pulumictl get version)
+VERSION := $(shell pulumictl get version --version-prefix 5.0.0)


If I run this locally, I get the correct behavior without this change.

$ git tag v5.0.0 $ pulumictl get version --language generic 5.0.0

That should cover releases produced via tags. I tried this with a few different tags as well.

Yes to get this behavior in CI you need to publish the tag, which might trigger a release :) And if CI-local fidelity is lost then some tests break.

AaronFriel · 2023-03-09T22:40:29Z

examples/regress_173_test.go

+  "response": {
+    "changes": "DIFF_SOME",
+    "diffs": [
+      "privateKeyPem",
+      "subject"
+    ]
+  },


Nit: Note that this test is checking that setAuthorityKeyId, setSubjectKeyId, allowedUses is not present by implementing state upgrade?

AaronFriel

This should prepare for a v5 release without issue, and we've already discussed fixes to ci-mgmt afterward to decouple major releases from ci-mgmt.

github-actions · 2023-03-09T22:51:11Z

Does the PR have any schema changes?

Found 3 breaking changes:
Resource "tls:index/certRequest:CertRequest" missing input "keyAlgorithm"
Resource "tls:index/locallySignedCert:LocallySignedCert" missing input "caKeyAlgorithm"
Resource "tls:index/selfSignedCert:SelfSignedCert" missing input "keyAlgorithm"
No new resources/functions.

t0yv0 mentioned this pull request Mar 3, 2023

Introduce PreStateUpgradeHook for Plugin Framework pulumi/pulumi-terraform-bridge#860

Merged

t0yv0 requested review from iwahbe and a team March 3, 2023 23:05

iwahbe reviewed Mar 6, 2023

View reviewed changes

t0yv0 added 9 commits March 8, 2023 11:06

Upgrade to Plugin Framework attempt 3

53be0a2

make build_sdks

773c920

Move regression tests under examples go.mod so that CI picks it up

34efdf7

Upgrade go mod refs

2c31ba6

tests -> examples

e66f209

Update examples go.mod

ff5219f

Update sdk go.mod

5ac03ac

make build_sdks

9bccea2

Update examples to remove the deprecated Algorithm parameters

38d707e

t0yv0 force-pushed the plugin-framework-3 branch from 7639a99 to 38d707e Compare March 8, 2023 16:21

t0yv0 added 5 commits March 8, 2023 14:13

Partially script major ver updates

e809ec3

go run scripts/new_major_version.go -ver v5 -name tls

ea73809

Move some of the go modules to v5

d76a577

Fixup Makefile and GoReleaser files

2f8ae24

Edit more refs

514c387

t0yv0 added 2 commits March 8, 2023 15:24

Ensure 5.x.x in the schema

77a9104

make build_sdks

9cf2d44

Revert --version-prefix

7913aad

Update example sdk refs to v5

d1db013

Pin version prefix to 5.0.0

2a121e8

t0yv0 requested review from iwahbe and a team March 8, 2023 22:45

t0yv0 commented Mar 8, 2023

View reviewed changes

Drop the scripts helper

7e9a59d

t0yv0 mentioned this pull request Mar 9, 2023

Allow providers to perform major version updates without ci-mgmt PRs pulumi/ci-mgmt#318

Closed

AaronFriel reviewed Mar 9, 2023

View reviewed changes

AaronFriel approved these changes Mar 9, 2023

View reviewed changes

Comment

705b586

t0yv0 merged commit 7c9d3d4 into master Mar 9, 2023

t0yv0 deleted the plugin-framework-3 branch March 9, 2023 23:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Plugin Framework #190

Update to Plugin Framework #190

t0yv0 commented Mar 3, 2023 •

edited

github-actions bot commented Mar 3, 2023

github-actions bot commented Mar 3, 2023

iwahbe left a comment

t0yv0 commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

t0yv0 Mar 8, 2023

t0yv0 Mar 8, 2023

t0yv0 Mar 8, 2023

AaronFriel Mar 9, 2023

t0yv0 Mar 9, 2023

t0yv0 commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

AaronFriel Mar 9, 2023

t0yv0 Mar 9, 2023

AaronFriel Mar 9, 2023

AaronFriel left a comment

github-actions bot commented Mar 9, 2023

		@@ -0,0 +1,103 @@
		// go run scripts/new_major_version.go -ver v5 -name tls goes part of the way to udpate all Go source references to a

		)

		replace github.com/pulumi/pulumi-tls/sdk/v5 => ../../../sdk

		@@ -1,18 +1,24 @@
		# NOTE: temporary hand edited to add --version-prefix.

Update to Plugin Framework #190

Update to Plugin Framework #190

Conversation

t0yv0 commented Mar 3, 2023 • edited

github-actions bot commented Mar 3, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 3, 2023

Does the PR have any schema changes?

iwahbe left a comment

Choose a reason for hiding this comment

t0yv0 commented Mar 8, 2023

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

github-actions bot commented Mar 8, 2023

Does the PR have any schema changes?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t0yv0 commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

Does the PR have any schema changes?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronFriel left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 9, 2023

Does the PR have any schema changes?

t0yv0 commented Mar 3, 2023 •

edited