Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform provider vault to v4.2.0 #466

Merged
merged 12 commits into from
Apr 1, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Apr 1, 2024

tries to address #458

the build_sdks step is failing with:

/Users/vvm/code/pulumi-vault/sdk/dotnet/Namespace.cs(64,26): error CS0101: The namespace 'Pulumi.Vault' already contains a definition for 'Namespace' [/Users/vvm/code/pulumi-vault/sdk/dotnet/Pulumi.Vault.csproj]

Looks like the Namespace resource is conflicting with the namespace module?

CSharpName: "TargetNamespace",
is probably relevant.

Copy link

github-actions bot commented Apr 1, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 3 breaking changes:

Resources

  • 🟢 "vault:kubernetes/secretBackendRole:SecretBackendRole": required: "allowedKubernetesNamespaces" property is no longer Required
  • "vault:secrets/syncAssociation:SyncAssociation": properties:
    • 🟡 "syncStatus" missing output "syncStatus"
    • 🟡 "updatedAt" missing output "updatedAt"

New functions:

  • index/getNamespace.getNamespace
  • index/getNamespaces.getNamespaces

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

github-actions bot commented Apr 1, 2024

Is README.md missing any configuration options?

addAddressToEnv not found in Configuration section
authLogin not found in Configuration section
authLoginAws not found in Configuration section
authLoginAzure not found in Configuration section
authLoginCert not found in Configuration section
authLoginGcp not found in Configuration section
authLoginJwt not found in Configuration section
authLoginKerberos not found in Configuration section
authLoginOci not found in Configuration section
authLoginOidc not found in Configuration section
authLoginRadius not found in Configuration section
authLoginTokenFile not found in Configuration section
authLoginUserpass not found in Configuration section
caCertDir not found in Configuration section
caCertFile not found in Configuration section
clientAuth not found in Configuration section
headers not found in Configuration section
maxLeaseTtlSeconds not found in Configuration section
maxRetries not found in Configuration section
maxRetriesCcc not found in Configuration section
setNamespaceFromToken not found in Configuration section
skipChildToken not found in Configuration section
skipGetVaultVersion not found in Configuration section
skipTlsVerify not found in Configuration section
tlsServerName not found in Configuration section
vaultVersionOverride not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@VenelinMartinov
Copy link
Contributor Author

@iwahbe not sure what to do here, would appreciate some help resolving this upgrade.

Comment on lines 2224 to 2238
"auto-settings": {
"datasources": {
"vault_namespace": {
"renames": [
"vault:namespace/get:get"
]
},
"vault_namespaces": {
"renames": [
"vault:namespace/getS:getS"
]
}
}
},
"renames": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these renames the issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. I regenerated everything after resetting bridge-metadata.json and SDKs seemed to build.

@VenelinMartinov VenelinMartinov merged commit 404491e into master Apr 1, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the upgrade-terraform-provider-vault-to-v4.2.0 branch April 1, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants