fix: Type checker inaccurately allows using 'id' property of a component resource #324

AaronFriel · 2022-08-26T21:33:42Z

Fixes the invalid Pulumi YAML program execution in #323, with this change the program in that issue will report an error like so:

pulumi:pulumi:Stack (k8s-aws-yaml-dev):
    error: id does not exist on vpc
    
      on Pulumi.yaml line 37:
      37:       vpcId: ${vpc.id}
    
    Existing properties are: eips, urn, vpc, vpcId, routes and 9 others

Hopefully pointing them in the direction of using vpc.vpcId.

iwahbe

LGTM

fix: Component resources do not output an 'id' property

60ad8ac

AaronFriel requested a review from iwahbe August 26, 2022 21:33

AaronFriel changed the title ~~fix: Component resources do not output an 'id' property~~ fix: Type checker inaccurately allows using 'id' property of a component resource Aug 26, 2022

iwahbe approved these changes Aug 29, 2022

View reviewed changes

chore: changelog

570b964

AaronFriel merged commit ab2c007 into main Aug 29, 2022

AaronFriel deleted the friel/components-lack-ids branch August 29, 2022 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Type checker inaccurately allows using 'id' property of a component resource #324

fix: Type checker inaccurately allows using 'id' property of a component resource #324

AaronFriel commented Aug 26, 2022

iwahbe left a comment

fix: Type checker inaccurately allows using 'id' property of a component resource #324

fix: Type checker inaccurately allows using 'id' property of a component resource #324

Conversation

AaronFriel commented Aug 26, 2022

iwahbe left a comment

Choose a reason for hiding this comment