Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on non-camelCase naming #362

Merged
merged 5 commits into from Oct 8, 2022
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 8, 2022

Fixes #355

Generated warnings look like this:

name: yaml
runtime: yAML
Resources:
  provider:
    type: pulumi:providers:aws
    PrOperties:
      region: us-east-1
    DefaultProvider: true
  bucket:
    Type: aws:s3:BucketV2
Diagnostics:
  pulumi:pulumi:Stack (yaml-dev):
    Warning: 'Resources' looks like a miscapitalization of 'resources'
      on Pulumi.yaml line 3:
       3: Resources:
    Pulumi YAML will enforce camelCase capitalization by GA. See https://github.com/pulumi/pulumi-yaml/issues/355 for details.
    Warning: 'PrOperties' looks like a miscapitalization of 'properties'
      on Pulumi.yaml line 6:
       6:     PrOperties:
    Pulumi YAML will enforce camelCase capitalization by GA. See https://github.com/pulumi/pulumi-yaml/issues/355 for details.
    Warning: 'DefaultProvider' looks like a miscapitalization of 'defaultProvider'
      on Pulumi.yaml line 8:
       8:     DefaultProvider: true
    Pulumi YAML will enforce camelCase capitalization by GA. See https://github.com/pulumi/pulumi-yaml/issues/355 for details.
    Warning: 'Type' looks like a miscapitalization of 'type'
      on Pulumi.yaml line 10:
      10:     Type: aws:s3:BucketV2
    Pulumi YAML will enforce camelCase capitalization by GA. See https://github.com/pulumi/pulumi-yaml/issues/355 for details.

@iwahbe iwahbe requested review from AaronFriel and aq17 October 8, 2022 00:15
@iwahbe iwahbe self-assigned this Oct 8, 2022
Copy link
Member

@AaronFriel AaronFriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a nit on the warning message.

iwahbe and others added 2 commits October 7, 2022 17:54
Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
@iwahbe iwahbe merged commit 326aba6 into main Oct 8, 2022
@iwahbe iwahbe deleted the iwahbe/355/make-naming-consistent branch October 8, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make case sensitivity consistent
2 participants