Do not error on duplicate config keys #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aq17
requested review from
AaronFriel,
iwahbe and
Frassle
and removed request for
iwahbe
AaronFriel
requested changes
Nov 7, 2022
AaronFriel
reviewed
Nov 8, 2022
pkg/tests/example_transpile_test.go
Outdated
| @@ -97,7 +97,8 @@ func TestGenerateExamples(t *testing.T) { | |||
| _, template, diags, err := codegen.LoadTemplate(exampleProjectDir) | |||
| require.NoError(t, err, "Loading project %v", dir) | |||
| require.False(t, diags.HasErrors(), diags.Error()) | |||
| assert.Len(t, diags, 0, "Should have neither warnings nor errors") | |||
| // TODO: update examples to use `config` instead of `configuration`. For now, allow the "`configuration` field is deprecated" warning. | |||
| // assert.Len(t, diags, 0, "Should have neither warnings nor errors") | |||
There was a problem hiding this comment.
Can we change this to a loop to filter out diags containing "`configuration` field is deprecated"?
|
@aq17 @AaronFriel Glad to see a test in here, just wasn't immediately obvious it was protecting against the duplicate config key issue that led to the problem. Does it cover that? If yes, great! If not, should we be adding a new test? |
|
It does & this PR removes the failure condition you found in #401. There are two follow ups here:
❯ cd $(mktemp -d)
/tmp/tmp.qP70vtV5Ub
❯ pulumi new kubernetes-gcp-yaml -y
Created project 'tmp.qP70vtV5Ub'
Please enter your desired stack name.
To create a stack in an organization, use the format <org-name>/<stack-name> (e.g. `acmecorp/dev`).
Created stack 'dev'
Saved config
Your new project is ready to go!
To perform an initial deployment, run `pulumi up`
/tmp/tmp.qP70vtV5Ub
❯ pulumi preview
Previewing update (dev)
View Live: https://app.pulumi.com/friel/tmp.qP70vtV5Ub/dev/previews/edac5652-3dbc-4f18-bbfe-e7ca55a5c84f
Type Name Plan Info
+ pulumi:pulumi:Stack tmp.qP70vtV5Ub-dev create 1 warning; 1 message
+ ├─ gcp:compute:Network gke-network create
+ ├─ gcp:compute:Subnetwork gke-subnet create
+ ├─ gcp:container:Cluster gke-cluster create
+ ├─ gcp:serviceAccount:Account gke-nodepool-sa create
+ └─ gcp:container:NodePool gke-nodepool create
Diagnostics:
pulumi:pulumi:Stack (tmp.qP70vtV5Ub-dev):
Warning: Pulumi.yaml: root-level `configuration` field is deprecated; please use `config` instead.
warning: unable to detect a global setting for GCP Project;
Pulumi will rely on per-resource settings for this operation.
Set the GCP Project by using:
`pulumi config set gcp:project <project>`
Outputs:
clusterId : output<string>
clusterName: "gke-cluster-2792fcd"
kubeconfig : [secret]
networkId : output<string>
networkName: "gke-network-f68e324" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401