Loosen constraint on int vs number type check

[aq17]

Fixes pu/templates pulumi/templates#465

Since the project-level config block supports integer but not number, we can loosen the type check constraint for now until configuration is fully deprecated

[iwahbe]

Can you show a repro here?

Pulumi YAML configuration does support int:

pulumi-yaml/pkg/pulumiyaml/config/config.go

Lines 142 to 144 in 55d4ae7

	case "int":
	return Int, true
	default:

[aq17]

Can you show a repro here?

Pulumi YAML configuration does support int:

pulumi-yaml/pkg/pulumiyaml/config/config.go

Lines 142 to 144 in 55d4ae7

	case "int":
	return Int, true
	default:

Ah right but config doesn't support Number. The template before the change used configuration with number, and I assumed if config was set on the cli it was parsed as integer causing the conflict. I'll try to repro to confirm first

[iwahbe]

Not all numbers are integers, so I don't love this fix. I think a repro would be helpful in root causing this.

[aq17]

The Pulumi.dev.yaml that gets initialized on pulumi new container-aws-yaml uses config, setting the keys as integer, whereas the old template with configuration tried to set it as number. Loosening the constraint to allow integer -> number should suffice for now

[iwahbe]

Would it be possible to add some tests here, both for correctness and to act as documentation for how the type coercion is supposed to work (int&float = float, int&int = int, int&string=!ok, ...)?