Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate fn::stackReference #420

Merged
merged 3 commits into from Dec 7, 2022
Merged

Deprecate fn::stackReference #420

merged 3 commits into from Dec 7, 2022

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Dec 6, 2022 •
edited

Fixes #285

Now that YAML is GA, fn::stackReference should be deprecated in favor of using the resource type pulumi:pulumi:StackResource.

@aq17 aq17 requested a review from iwahbe December 6, 2022 19:54
@aq17 aq17 changed the title Warn on fn::stackReference Deprecate fn::stackReference Dec 6, 2022
iwahbe
iwahbe approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG_PENDING.md Show resolved Hide resolved
@aq17 @iwahbe
Update CHANGELOG_PENDING.md
1f06af7 
Co-authored-by: Ian Wahbe <ian@wahbe.com>
@aq17 aq17 merged commit 0af2103 into main Dec 7, 2022
@aq17 aq17 deleted the aqiu/285-warn branch December 7, 2022 17:42
@aq17 aq17 self-assigned this Dec 7, 2022
@aq17 aq17 added this to the 0.82 milestone Dec 7, 2022
@desteves desteves added the impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees

@aq17 aq17

Labels
impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation
Projects
None yet
Milestone
0.82
Development

Successfully merging this pull request may close these issues.

Deprecate Fn::StackReference
3 participants
@aq17 @iwahbe @desteves