Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
13017: [pcl/binder] Include the component source directory in diagnostics when reporting PCL errors r=Zaid-Ajaj a=Zaid-Ajaj # Description Include the component source directory in diagnostics when reporting PCL errors. Usually when a PCL component reports an error, the `Subject` of the diagnostic is only a file name like `main.pp` but that is not enough information in programs with many components that have that same file name. This PR addresses the issue and replaces the `Subject` of diagnostic errors to the full path of the component directory. Fixes #13015 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
- Loading branch information