-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot up dynamically created stacks using 3.40.2 #10862
Comments
What's your Pulumi.yaml in /infra look like? Does it have "config" set? |
Yes. Pulumi.yaml name: myName
runtime: dotnet
description: someDEsc
config:
azure-native:location: norwayeast |
@johnkors as of now, the project file doesn't read configuration from the That said, I am working on Hierarchical and structured config implementation: the initial pass which make your use case viable, but it is still work-in-progress |
Sounds like a breaking change in a patch to me (3.40.2 now contains breaking changes compared to 3.40.0). How about instead of throwing errors, you provide a warning explaining a way of migration to the "new" way of using config? |
We didn't change how
As of now, you can only use the |
Ah, I think I understand what has happened here. I had a In 3.40.2 you re-used this deprecated attribute for something else. Breaks back compat, but yeah - now I understand why at least. |
Same problem. After changing the version to 3.40.0, the deployment works. Also, I find it interesting that 8 days ago version 3.40.1 was released, yet in my Github action yesterday the official Pulumi action used version 3.40.0 even though I did not specify an exact version. |
Yeah, got it. This broke for developers using a an old Pulumi.yaml not yet migrated (meaning removing their config from the YAML). I get why you don't see it as a breaking change, though — but this will probably affect everyone with an old Pulumi.yaml. Probably very common to update the CLI, but not touch the yaml. I haven't at least been aware of that I should remove the config section (again: should perhaps provide a warning about it being deprecated..?). I think the safest option would for the new feature of config to not re-use an old deprecated attribute, but use a new one |
We do. "config" has never supported setting actual config options before. It used to be used to set the path to store config yaml files at, and it can still be used for that but we do also now have "configPath" to set that which will eventually be the only supported way. When we add top level config support we will also continue to allow "config" to just be a string point to the folder path but obviously if you want to make use of the new top level config support that will have to be moved to "configPath". The only thing that changed regarding config between 3.40.0 and 3.40.2 is that now when we read the Pulumi.yaml we assert that it's actually correct. The |
Ok, sorry, sorry. Thanks for detailing this out. I have no way of verifying if it was added via tooling or a copy-paste issue, but then most likely this is then caused by me manually adding an invalid config property to I think I might have wrongly assumed it supported "default" values at some point back when. |
Correct, "config" is currently only valid in |
Would have been hilarious if what I wrongly assumed working just started to work when you released it 😆. But if I understand, it will be solved differently to what I tried here. Closing this issue anyways. Thanks alot! |
What happened?
3.40.0 can up dynamically created stacks (eg. pr pull request)
3.40.2 errors when up'-ing a dynamically created stack
Steps to reproduce
We're creating stacks dynamically using github actions:
Errorlog:
Expected Behavior
Being able to
up
the stack.Actual Behavior
Errors:
Output of
pulumi about
Can be provided if necessary
Additional context
Reverting to pulumi-version: 3.40.0 fixes the issue and works as expected.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: