pulumi new hitting error: cloning templates repo: worktree contains unstaged changes
#11121
Comments
lukehoban
added
kind/bug
|
This might be a go-git issue: go-git/go-git#511 |
|
I've been trying to repro this but so far re-cloning the repo or resetting templates to non-head commits isn't triggering it. I've written up #11124 quickly to try and report better errors here, hopefully someone can run that and hit and report the error to give some hints as to what's going on here. |
|
Hmm, I just hit this. I then rebuilt with the changes from #11124 and now I'm not seeing the error anymore. |
11117: Airgap sdk gen tests r=iwahbe a=iwahbe <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> This PR provides the test host to our sdk generation tests. Previously, we were downloading plugins as needed for external packages. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11124: Report unstaged changes from GitCloneOrPull r=justinvp a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> To help with #11121 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Ian Wahbe <ian@wahbe.com> Co-authored-by: Fraser Waters <fraser@pulumi.com>
11124: Report unstaged changes from GitCloneOrPull r=justinvp a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> To help with #11121 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com>
|
I just hit this as well. Just ran |
|
i just hit this as well and was told to report it here
|
|
Hit it again. Here's the details: |
I think some confusion has happened with ignore settings and this file. It looks like "metadata.json" was added to .gitignore, then removed from .gitignore and added to the repository. I wonder if go-git hasn't handled that transition well? Although that wouldn't explain how @justinvp saw this twice. Could something be deleting this file? |
|
Same here: $ pulumi new aws-python
error: cloning templates repo: GitCloneOrPull reported unstaged changes: metadata/dist/metadata.json was D |
Yes, that appears to be the problem; some issue with go-git not handling this well. It looks like this can happen for anyone who has run WorkaroundFor anyone affected by this, you can workaround the problem by simply deleting your FixWe'll work on a fix to the CLI itself that will effectively do the |
|
WIP fix: master...justin/gitreset |
|
I just tried to pull a template and got: |
Several users have reported seeing this occasionally recently. Retrying seems to always work - but we should make sure this does not fail in the first place.
The text was updated successfully, but these errors were encountered: