Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/py: macOS builds build gRPC from source #12054

Closed
abhinav opened this issue Feb 3, 2023 · 1 comment · Fixed by #12066
Closed

ci/py: macOS builds build gRPC from source #12054

abhinav opened this issue Feb 3, 2023 · 1 comment · Fixed by #12066
Assignees
@abhinav
Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.84

Comments

@abhinav
Copy link
Contributor

abhinav commented Feb 3, 2023

macOS CI builds appear to build grpcio from source
instead of downloading a pre-built wheel.

This can add a fair bit of time to our builds.

We should fix this.
This was referenced Feb 3, 2023
Closed
Closed
Merged
abhinav added a commit that referenced this issue Feb 3, 2023
@abhinav
ci: Use macos-latest
8adb856 
In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.

This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).

To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.

Resolves #12054, #12050
abhinav added a commit that referenced this issue Feb 3, 2023
@abhinav
ci: Use macos-latest
df8ace1 
In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.

This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).

To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.

Resolves #12054, #12050
bors bot added a commit that referenced this issue Feb 3, 2023
@bors @abhinav
Merge #12066
e6f31ef 
12066: ci: Use macos-latest r=abhinav a=abhinav

In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.

This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).

To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.

Resolves #12054, #12050


Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
@bors bors bot closed this as completed in 4955f3d Feb 3, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 3, 2023
@pulumi-bot pulumi-bot reopened this Feb 3, 2023
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: kind/

@abhinav abhinav added area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user labels Feb 3, 2023
@abhinav abhinav closed this as completed Feb 3, 2023
phillipedwards pushed a commit that referenced this issue Feb 8, 2023
@abhinav @phillipedwards
ci: Use macos-latest
d1338fc 
In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.

This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).

To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.

Resolves #12054, #12050
@mikhailshilkov mikhailshilkov added this to the 0.84 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinav abhinav

Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.84
Development

Successfully merging a pull request may close this issue.

ci: Use macos-latest pulumi/pulumi
3 participants
@abhinav @mikhailshilkov @pulumi-bot