Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go-git to v5.6.0 to remove cgo dependency #12309

Closed
dixler opened this issue Feb 28, 2023 · 0 comments · Fixed by #12310
Closed

Bump go-git to v5.6.0 to remove cgo dependency #12309

dixler opened this issue Feb 28, 2023 · 0 comments · Fixed by #12310
Assignees
@dixler
Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.85

Comments

@dixler
Copy link
Contributor

dixler commented Feb 28, 2023 •
edited

The current version of go-git depends on cgo.

This cgo dependency is breaking our releases in pulumi-docker-containers
pulumi/pulumi-docker-containers#127

go-git release v5.6.0 has removed the cgo dependency
https://github.com/go-git/go-git/releases/tag/v5.6.0
@dixler dixler added area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user labels Feb 28, 2023
@dixler dixler self-assigned this Feb 28, 2023
@dixler dixler added this to the 0.85 milestone Feb 28, 2023
@dixler dixler mentioned this issue Feb 28, 2023
Merged
3 tasks
bors bot added a commit that referenced this issue Mar 1, 2023
@bors
Merge #12310
9265512 
12310: Bump go-git to v5.6.0 to remove cgo dependency. r=dixler a=dixler

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

This PR removes a cgo dependency from pulumi which broke builds in pulumi-docker-containers (see pulumi/pulumi-docker-containers#127).

go-git introduced a cgo dependency they have removed the dependency as of https://github.com/go-git/go-git/releases/tag/v5.6.0 and this PR bumps our version of go-git to that version.

Fixes #12309 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Kyle Dixler <kyle@pulumi.com>
@bors bors bot closed this as completed in 97fb30e Mar 1, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dixler dixler

Labels
area/build CI/CD for pulumi/pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.85
Development

Successfully merging a pull request may close this issue.

Bump go-git to v5.6.0 to remove cgo dependency. pulumi/pulumi
2 participants
@dixler @pulumi-bot