Generate and publish NPM package with install-pulumi-plugin.js

[AaronFriel]

Recently published NPM packages by the ecosystem team have failed to install, on failing to execute a script scripts/install-pulumi-plugin.js. See:

• NPM package install failure on v5.44.0 pulumi-azure#1301
• NPM Publishing step does not include scripts/install-pulumi-plugin.js pulumi-package-publisher#10

[Frassle]

Commented on pulumi/pulumi-package-publisher#10 (comment) so just linking that here for visibility.

[justinvp]

I think the root cause of this is actually a Node.js sdkgen bug. We do emit the scripts/install-pulumi-plugin.js file as part of sdkgen, but when running tsc to build, the JavaScript file doesn't actually get copied into bin/scripts because it isn't a TypeScript file and isn't listed in tsconfig.json.

Originally, sdkgen did not emit this file at all. Our publishing script injected it into the package before publishing: https://github.com/pulumi/scripts/blob/b6ee1692954d2b39e7a22b0db80b8cc4b735c101/ci/publish-tfgen-package#L33-L42. This ends up running add-plugin-installer-script.js, which adds this copy of install-pulumi-plugin.js into the package.

Eventually we changed sdkgen to emit this file in #8730, but since this file never got "built" and copied into the built directory along with all the other compiled javascript, it was never actually included in the published package. Instead the variant of install-pulumi-plugin.js from the https://github.com/pulumi/scripts repo was being published.

We should fix the Node.js sdkgen to emit a scripts/install-pulumi-plugin.ts TypeScript file (rather than a JavaScript file), and list it in tsconfig.json so that it is copied to the bin/scripts/install-pulumi-plugin.js as part of compiling the TypeScript to JavaScript. (Or, possibly use "allowJs": true in tsconfig.json and list the .js file there, so it is copied over to the built dir).

We may have to update any publish scripts and commands to avoid injecting a scripts/install-pulumi-plugin.js if one already exists.

[Frassle]

Honestly wonder if we should just do #13075 and drop these files entirely. NodeJS is going to be the only language where this works via library files, not totally sure it's worth the special treatment.

[Frassle]

Closing this as we've changed codegen to drop these files entirely now.

[pulumi-bot]

Cannot close issue:

• does not have an assignee

Please fix these problems and try again.