Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter or new method to allow pulumi stack ls -a #14226

Closed
phillipedwards opened this issue Oct 11, 2023 · 3 comments · Fixed by #16266
Closed

Add parameter or new method to allow pulumi stack ls -a #14226

phillipedwards opened this issue Oct 11, 2023 · 3 comments · Fixed by #16266
Assignees
@zbuchheit
Labels
area/automation-api customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@phillipedwards
Copy link
Member

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

currently, automation api allows for listing all stacks within a project but not all stacks in the scope of a user. Eg- pulumi stack ls -a.

Affected area/feature

add a new method or flag to allow this behavior to be achieved.
@phillipedwards phillipedwards added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Oct 11, 2023
@justinvp justinvp added area/automation-api and removed needs-triage Needs attention from the triage team labels Oct 12, 2023
@zbuchheit zbuchheit added customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs labels May 2, 2024
@zbuchheit
Copy link
Contributor

@justinvp @Frassle I am curious your thoughts as to how/where this might be implemented given the automation api and cli design. I looked at the code base and didn't really see an obvious spot where this would land given it is a more of an org-scoped command.

@phillipedwards
Copy link
Member Author

I implemented this for go but (1) tests were still failing and I havent resolved them (2) I hate doing SDK specific things...
https://github.com/pulumi/pulumi/tree/pedwards/aa-list-all-stacks

@zbuchheit
Copy link
Contributor

hmm makes sense. I guess I was overthinking it. Really just would require a local workspace which can always just be a basic temp dir to run the command with.

@zbuchheit zbuchheit mentioned this issue May 24, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 3, 2024
@zbuchheit @tgummerer
Add support for --all parameter of the stack ls command to the Au…
0ebfde2 
…tomation API (#16266)

<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

Adds Go/Nodejs/Python automation API support for pulumi stack ls --all.

Fixes: [#14226](#14226)

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

---------

Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbuchheit zbuchheit

Labels
area/automation-api customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for --all parameter of the stack ls command to the Automation API pulumi/pulumi
4 participants
@justinvp @phillipedwards @zbuchheit @pulumi-bot