Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pnpm #15455

Closed
Tracked by #12688
julienp opened this issue Feb 16, 2024 · 0 comments · Fixed by #15456
Closed
Tracked by #12688

Support pnpm #15455

julienp opened this issue Feb 16, 2024 · 0 comments · Fixed by #15456
Assignees
@julienp
Labels
area/sdks Pulumi language SDKs kind/enhancement Improvements or new features language/javascript resolution/fixed This issue was fixed

Comments

@julienp
Copy link
Contributor

julienp commented Feb 16, 2024 •
edited

Support pnpm as a package manager.

If we detect a pnpm-lock.yaml next to the package.json, we use pnpm.
@julienp julienp mentioned this issue Feb 16, 2024
Closed
@julienp julienp self-assigned this Feb 16, 2024
@julienp julienp added area/sdks Pulumi language SDKs kind/enhancement Improvements or new features language/javascript labels Feb 16, 2024
@julienp julienp mentioned this issue Feb 16, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 21, 2024
@julienp
Use pnpm as package manager if we find a pnpm-lock.yaml file (#15456)
2a2d247 
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

Initial support pnpm. Note that this does not support pnpm workspaces
yet.

This also does not handle passing the package manager through from
`pulumi new`. Once a user manually runs pnpm, creating a pnpm-lock.yaml,
we'll detect that and pnpm.

Fixes #15455

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienp julienp

Labels
area/sdks Pulumi language SDKs kind/enhancement Improvements or new features language/javascript resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pnpm as package manager if we find a pnpm-lock.yaml file pulumi/pulumi
2 participants
@julienp @pulumi-bot