-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xRegisterStackTransform causes an error if there is no stack outputs in Typescript #15973
Closed
Tracked by
#12996
Labels
area/transforms
Old style SDK based or engine based transforms
customer/feedback
Feedback from customers
customer/lighthouse
Lighthouse customer bugs
kind/bug
Some behavior is incorrect or out of spec
language/javascript
resolution/fixed
This issue was fixed
Milestone
Comments
zbuchheit
added
kind/bug
Some behavior is incorrect or out of spec
needs-triage
Needs attention from the triage team
customer/feedback
Feedback from customers
customer/lighthouse
Lighthouse customer bugs
labels
Apr 17, 2024
zbuchheit
changed the title
xRegisterStackTransform causes an error if there is no stack outputs
xRegisterStackTransform causes an error if there is no stack outputs in Typescript
Apr 17, 2024
Frassle
added
area/transforms
Old style SDK based or engine based transforms
language/javascript
labels
Apr 19, 2024
Similar to #15984 looks like this is something specific about component providers. We already have tests for normal resources and stack transforms without outputs that work fine. |
Ah nope got a repro with just a single normal custom resource, it's just intermittent. |
Frassle
added a commit
that referenced
this issue
Apr 19, 2024
6 tasks
Frassle
added a commit
that referenced
this issue
Apr 19, 2024
Frassle
added a commit
that referenced
this issue
Apr 19, 2024
Frassle
added a commit
that referenced
this issue
Apr 22, 2024
21 tasks
Frassle
added a commit
that referenced
this issue
Apr 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 23, 2024
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #15973. Ensures that the `rpcDone` promise covers the whole async operation atomically. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/transforms
Old style SDK based or engine based transforms
customer/feedback
Feedback from customers
customer/lighthouse
Lighthouse customer bugs
kind/bug
Some behavior is incorrect or out of spec
language/javascript
resolution/fixed
This issue was fixed
What happened?
While attempting to use xRegisterStackTransform I encountered the following error when I don't have a stack output set.
Example
Repro Code
Repro Steps
pulumi up
Output of
pulumi about
Additional context
This appears specific to Typescript as Python doesn't produce the same error with equivalent code.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: