Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require --force to remove stacks with resources #2431

Closed
joeduffy opened this issue Feb 6, 2019 · 0 comments
Closed

Require --force to remove stacks with resources #2431

joeduffy opened this issue Feb 6, 2019 · 0 comments
Assignees
@ellismg
Labels
area/cli UX of using the CLI (args, output, logs) kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer
Milestone
0.21

Comments

@joeduffy
Copy link
Member

joeduffy commented Feb 6, 2019

We seem to have regressed our prior behavior where attempting to remove a stack still containing resources was rejected unless --force is passed. This is a dangerous operation, especially as today there's no way to recover the old stack, and we should definitely bring back the old behavior.

Let's also make sure to add a test case to protect against regressing again in the future.
@joeduffy joeduffy added kind/bug Some behavior is incorrect or out of spec area/cli UX of using the CLI (args, output, logs) area/service p1 A bug severe enough to be the next item assigned to an engineer labels Feb 6, 2019
@joeduffy joeduffy added this to the 0.21 milestone Feb 6, 2019
ellismg added a commit that referenced this issue Feb 7, 2019
@ellismg
Show a better error when --force needs to be passed to stack rm
c385473 
When `pulumi stack rm` is run against a stack with resources, the
service will respond with an error if `--force` is not
passed. Previously we would just dump the contents of this error and
it looked something like:

`error: [400] Bad Request: Stack still has resources.`

We now handle this case more gracefully, showing our usual "this stack
still has resources" error like we would for the local backend.

Fixes #2431
@ellismg ellismg closed this as completed in 687a780 Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellismg ellismg

Labels
area/cli UX of using the CLI (args, output, logs) kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer
Projects
None yet
Milestone
0.21
Development

No branches or pull requests
2 participants
@joeduffy @ellismg