Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new should validate secrets provider eagerly #2727

Closed
joeduffy opened this issue May 14, 2019 · 1 comment
Closed

new should validate secrets provider eagerly #2727

joeduffy opened this issue May 14, 2019 · 1 comment
Assignees
@ellismg
Labels
area/cli UX of using the CLI (args, output, logs) kind/bug Some behavior is incorrect or out of spec
Milestone
0.23

Comments

@joeduffy
Copy link
Member

joeduffy commented May 14, 2019 •
edited
Loading

If I type in a bad secrets provider when creating a new project via new

$ pulumi new --secrets-provider bad

I don't get an error until I get to the stack creation part:

stack name: (dev)
Sorry, could not create stack 'dev': unknown secrets provider type 'bad'

At this point, the CLI then just keeps asking me for the stack name. No matter what I do, however, I'm stuck, since I passed the bad secrets provider long ago.
@joeduffy joeduffy added kind/bug Some behavior is incorrect or out of spec area/cli UX of using the CLI (args, output, logs) labels May 14, 2019
@joeduffy joeduffy added this to the 0.23 milestone May 14, 2019
@joeduffy
Copy link
Member Author

As an aside, what is the gesture I'm meant to run to tell me which providers are available? I hoped the help text would tell me, but alas it does not:

The name of the provider that should be used to encrypt and decrypt secrets.

(minor nit, this help text ends in a ., while none of the other options do)

ellismg added a commit that referenced this issue May 15, 2019
@ellismg
Eagerly validate secrets-provider option
af20135 
Validate the value is well formed much earlier so you don't end up
seeing you've picked a bad value in the middle of trying to create
your new stack. Update the helptext to list currently supported
values.

Fixes #2727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellismg ellismg

Labels
area/cli UX of using the CLI (args, output, logs) kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
0.23
Development

No branches or pull requests
2 participants
@joeduffy @ellismg