Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate Go inputty types for output-only schema types #8194

Closed
mikhailshilkov opened this issue Oct 12, 2021 · 1 comment · Fixed by #7943
Closed

Do not generate Go inputty types for output-only schema types #8194

mikhailshilkov opened this issue Oct 12, 2021 · 1 comment · Fixed by #7943
Assignees
@pgavlin
Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/enhancement Improvements or new features language/go resolution/fixed This issue was fixed size/M Estimated effort to complete (up to 5 days).
Milestone
0.66

Comments

@mikhailshilkov
Copy link
Member

A lot of schema types in some providers (azure-native, google-native) are output-put, i.e. they are used to define the structure of resource outputs but never resource inputs. For example, in azure-native those types will have a Response suffix.

Our current Go codegen would generate a full set for types for those schema types, including inputty types. In order to reduce the size of Go SDKs, particularly in azure-native, it would make sense to avoid generating those unneeded types.
@mikhailshilkov mikhailshilkov added language/go area/codegen SDK-gen, program-gen, convert labels Oct 12, 2021
@mikhailshilkov mikhailshilkov added this to the 0.63 milestone Oct 12, 2021
@mikhailshilkov mikhailshilkov mentioned this issue Oct 12, 2021
Merged
@mikhailshilkov mikhailshilkov added kind/enhancement Improvements or new features impact/performance Something is slower than expected labels Oct 12, 2021
@emiliza emiliza modified the milestones: 0.63, 0.64 Oct 25, 2021
@emiliza emiliza modified the milestones: 0.64, 0.65 Nov 16, 2021
@emiliza emiliza added the size/M Estimated effort to complete (up to 5 days). label Dec 2, 2021
@emiliza emiliza modified the milestones: 0.65, 0.66 Dec 6, 2021
@emiliza emiliza added the resolution/fixed This issue was fixed label Dec 10, 2021
@emiliza
Copy link
Contributor

emiliza commented Dec 10, 2021

Closing, fixed by #7943

@emiliza emiliza closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgavlin pgavlin

Labels
area/codegen SDK-gen, program-gen, convert impact/performance Something is slower than expected kind/enhancement Improvements or new features language/go resolution/fixed This issue was fixed size/M Estimated effort to complete (up to 5 days).
Projects
None yet
Milestone
0.66
Development

Successfully merging a pull request may close this issue.

Do not generate Go inputty types for output-only schema types pulumi/pulumi
3 participants
@pgavlin @mikhailshilkov @emiliza