Do not generate Go inputty types for output-only schema types #7943
Conversation
|
Diff for pulumi-random with merge commit ea68bf9 |
|
Diff for pulumi-azuread with merge commit ea68bf9 |
|
Diff for pulumi-kubernetes with merge commit ea68bf9 |
|
Diff for pulumi-aws with merge commit ea68bf9 |
|
Diff for pulumi-gcp with merge commit ea68bf9 |
|
Diff for pulumi-azure with merge commit ea68bf9 |
pgavlin
force-pushed
the
mikhailshilkov/reduce-go-input-types
branch
from
b226d9e
to
c818919
Compare
|
Diff for pulumi-azuread with merge commit 9ec1554 |
|
Diff for pulumi-random with merge commit 9ec1554 |
|
Diff for pulumi-kubernetes with merge commit 9ec1554 |
|
Diff for pulumi-gcp with merge commit 9ec1554 |
|
Diff for pulumi-azure with merge commit 9ec1554 |
|
Diff for pulumi-aws with merge commit 9ec1554 |
- Remove enumElementType, whose functionality duplicates work done in argsTypeImpl - Clarify the args- vs. Go-ness of the two element types This is prep work for #7943.
- Remove enumElementType, whose functionality duplicates work done in argsTypeImpl - Clarify the args- vs. Go-ness of the two element types This is prep work for #7943. These changes should not produce codegen diffs.
pgavlin
force-pushed
the
mikhailshilkov/reduce-go-input-types
branch
from
bedb11c
to
4de357f
Compare
|
Diff for pulumi-random with merge commit ff7782b |
|
Diff for pulumi-azuread with merge commit ff7782b |
|
Diff for pulumi-kubernetes with merge commit ff7782b |
|
Diff for pulumi-gcp with merge commit ff7782b |
pgavlin
force-pushed
the
mikhailshilkov/reduce-go-input-types
branch
from
de51d2e
to
92bdc83
Compare
|
Diff for pulumi-azuread with merge commit dff3b94 |
|
Diff for pulumi-random with merge commit dff3b94 |
|
Diff for pulumi-kubernetes with merge commit dff3b94 |
|
Diff for pulumi-gcp with merge commit dff3b94 |
|
Diff for pulumi-azure with merge commit dff3b94 |
|
Diff for pulumi-aws with merge commit dff3b94 |
|
Yeah we need this change asap, I'm in favor. LMK if need another review or dig in on some specifics. |
|
Diff for pulumi-azure-native with merge commit dff3b94 |
There was a problem hiding this comment.
Except my previous items, I think this looks good. Like @t0yv0, I'm relying heavily on downstream tests to supplement correctness checks. I think that the change would result in compile time errors more than runtime errors, so downstream is a powerful check here.
These changes prevent the Go SDK generator from generating input
types that are never referenced by rest of the generated SDK. For
example, if an object type never appears in a resource input property,
these changes will prevent an input type from being generated for
that object type. In further pursuit of this goal, these changes prevent
the generation of input/output types for function inputs and arguments
if function output versions are disabled or if the function does not need
an output form.
In order to preserve backwards compatibility, the extra input types can
be retained by setting the
generateExtraInputTypesproperty in theGo language options for a Pulumi package.
The goal of these changes is to reduce the size of Go SDK, particularly
for Azure-Native.
Fixes: #8194