Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deeply nested protobuf objects in python #10284

Merged
merged 8 commits into from Jul 29, 2022
Merged

Support deeply nested protobuf objects in python #10284

merged 8 commits into from Jul 29, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Jul 29, 2022 •
edited

Description

Fixes #10281

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle mentioned this pull request Jul 29, 2022
Closed
@Frassle Frassle marked this pull request as ready for review July 29, 2022 10:40
@Frassle Frassle requested review from iwahbe and Zaid-Ajaj July 29, 2022 10:40
@Frassle Frassle changed the title Add recursion test to python Support deeply nested protobuf objects in python Jul 29, 2022
Zaid-Ajaj
Zaid-Ajaj approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test LGTM, can merge with CI is green

@Frassle Frassle merged commit 65ccad4 into master Jul 29, 2022
@pulumi-bot pulumi-bot deleted the fraser/pythonRecusionLimit branch July 29, 2022 15:17
mikhailshilkov added a commit that referenced this pull request Jul 29, 2022
@mikhailshilkov
Revert #10284
3d49b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaid-Ajaj Zaid-Ajaj Zaid-Ajaj approved these changes

@iwahbe iwahbe iwahbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when using k8s.yaml.ConfigFile
3 participants
@Frassle @Zaid-Ajaj @iwahbe