ci: Re-enable checksums #10708
Merged
ci: Re-enable checksums #10708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
added
the
impact/no-changelog-required
AaronFriel
force-pushed
the
friel/bors-checksums
branch
from
4eae62f
to
0eeea47
Compare
Changelog[uncommitted] (2022-09-14) |
kpitzen
approved these changes
Sep 14, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2022
10708: ci: Re-enable checksums r=AaronFriel a=AaronFriel In the absence of key distribution or attestation of a "proper" signing key for now, this enables the "sign" job which adds checksum artifacts, sans signatures. This leaves open the possibility of using sigstore.dev & tooling, or some other tooling to sign artifacts. Fixes #10707. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
t0yv0
approved these changes
Sep 14, 2022
|
Build failed: |
|
bors retry |
1 similar comment
|
bors retry |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2022
10702: Prep for real 3.40.0 release r=AaronFriel a=AaronFriel This turns the "safeties off" after validating the bors workflow and ensuring everything up to the dispatch commands succeeds. It also fixes an error in `get-next-version` that resulted in the "vNext" PR #10701 to calculate the wrong "next version", which was corrected by hand. (The branch name and commit history is evidence of the error.) 10703: Delete CHANGELOG_PENDING.md r=AaronFriel a=AaronFriel 10708: ci: Re-enable checksums r=AaronFriel a=AaronFriel In the absence of key distribution or attestation of a "proper" signing key for now, this enables the "sign" job which adds checksum artifacts, sans signatures. This leaves open the possibility of using sigstore.dev & tooling, or some other tooling to sign artifacts. Fixes #10707. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Sep 14, 2022
10703: Delete CHANGELOG_PENDING.md r=AaronFriel a=AaronFriel 10708: ci: Re-enable checksums r=AaronFriel a=AaronFriel In the absence of key distribution or attestation of a "proper" signing key for now, this enables the "sign" job which adds checksum artifacts, sans signatures. This leaves open the possibility of using sigstore.dev & tooling, or some other tooling to sign artifacts. Fixes #10707. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
bors merge |
|
Already running a review |
|
Build failed (retrying...): |
AaronFriel
force-pushed
the
friel/bors-checksums
branch
from
0eeea47
to
142df65
Compare
|
Canceled. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of key distribution or attestation of a "proper" signing key for now, this enables the "sign" job which adds checksum artifacts, sans signatures.
This leaves open the possibility of using sigstore.dev & tooling, or some other tooling to sign artifacts.
Fixes #10707.