Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updated test repo, check if Windows tests pass #10821

Merged
merged 2 commits into from Sep 22, 2022
Merged

ci: Updated test repo, check if Windows tests pass #10821

merged 2 commits into from Sep 22, 2022

Conversation

AaronFriel
Copy link
Member

The remote repo has been updated to use the latest Go & Pulumi SDK, so this ought to unblock these tests.

Resolves #8646.

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Sep 21, 2022

Changelog

[uncommitted] (2022-09-22)

@AaronFriel AaronFriel added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 21, 2022
@AaronFriel
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Sep 22, 2022
10731: add `buildTarget` option for pulumi go programs to compile/recompile to the specified path r=dixler a=dixler

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Part of #10473 

This implements the `buildTarget` option(Pulumi.yaml) for Pulumi Go programs to write the pulumi program out to a file. It has some performance benefits as Go can build a program faster when an existing program is provided.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [x] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have updated the [CHANGELOG-PENDING](https://github.com/pulumi/pulumi/blob/master/CHANGELOG_PENDING.md) file with my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


10817: Add pulumi-analyzer-policy and pulumi-analyzer-policy-python to the list of bundled plugins r=Frassle a=Frassle

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes discovering these plugins if the directory "pulumi[.exe]" is in is not on PATH.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


10821: ci: Updated test repo, check if Windows tests pass r=AaronFriel a=AaronFriel

The remote repo has been updated to use the latest Go & Pulumi SDK, so this ought to unblock these tests.

Resolves #8646.

Co-authored-by: Kyle Dixler <kyle@pulumi.com>
Co-authored-by: Fraser Waters <fraser@pulumi.com>
Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
@bors
Copy link
Contributor

bors bot commented Sep 22, 2022

Build failed (retrying...):

@bors
Copy link
Contributor

bors bot commented Sep 22, 2022

Canceled.

@AaronFriel
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 22, 2022

Build succeeded:

@bors bors bot merged commit f033d9d into master Sep 22, 2022
@bors bors bot deleted the friel/8646 branch September 22, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test maintenance: fix local_workspace_test on Windows
3 participants