Refactor convert command to add entrypoint for pulumi convert debugging #10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-04) |
aq17
approved these changes
Sep 29, 2022
AaronFriel
added
the
impact/no-changelog-required
iwahbe
approved these changes
Sep 29, 2022
AaronFriel
force-pushed
the
friel/easy-convert-debug
branch
from
a2f124c
to
6a1751e
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
3 tasks
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. 10921: ci: Unblock local ProgramTest usage r=AaronFriel a=AaronFriel The first commit removes a redundant check to skip the test in `prepareProgram`, given the check in `newProgramTester`: https://github.com/pulumi/pulumi/blob/2b1b4fb0b4d6d2c32cd1303957babc2942703eb4/pkg/testing/integration/program.go#L761-L769 The second refactors the two functions, given that both are private to the test package and `prepareProgram` is called if and only if it's immediately followed by `newProgramTest`. The former is now a side-effecting function that mutates its options, the latter is a pure constructor. 10928: chore: Update go modules via go mod tidy r=Frassle a=kpitzen <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes # (issue) ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 10930: ci: Enable gh cli in every step of job r=AaronFriel a=AaronFriel Fixes the issue where the `gh` CLI reported that no token was present: https://github.com/pulumi/pulumi/actions/runs/3145787399/jobs/5113494314 Co-authored-by: Aaron Friel <mayreply@aaronfriel.com> Co-authored-by: Kyle Pitzen <kyle.pitzen@gmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. 10921: ci: Unblock local ProgramTest usage r=AaronFriel a=AaronFriel The first commit removes a redundant check to skip the test in `prepareProgram`, given the check in `newProgramTester`: https://github.com/pulumi/pulumi/blob/2b1b4fb0b4d6d2c32cd1303957babc2942703eb4/pkg/testing/integration/program.go#L761-L769 The second refactors the two functions, given that both are private to the test package and `prepareProgram` is called if and only if it's immediately followed by `newProgramTest`. The former is now a side-effecting function that mutates its options, the latter is a pure constructor. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. 10932: sdk/go: Move unsafe API to internals package r=AaronFriel a=AaronFriel Following internal discussion, expose this function on a separate package: `sdk/v3/go/pulumi/internals`. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
bors bot
added a commit
that referenced
this pull request
Oct 5, 2022
10879: Refactor convert command to add entrypoint for pulumi convert debugging r=AaronFriel a=AaronFriel This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point. This codifies the approach I've used (writing micro programs after modifying `convert.go`) to debug panics in Pulumi YAML. 10932: sdk/go: Move unsafe API to internals package r=AaronFriel a=AaronFriel Following internal discussion, expose this function on a separate package: `sdk/v3/go/pulumi/internals`. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the bulk of the convert logic into a function that can be run in a unit test, along with a trivial unit test entry point.
This codifies the approach I've used (writing micro programs after modifying
convert.go) to debug panics in Pulumi YAML.