Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gocloud.dev to 0.27.0. #10900

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

ekini
Copy link
Contributor

@ekini ekini commented Oct 3, 2022

Description

Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication.

Run go mod tidy.

Fixes #7251

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change

Summary

The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars AZURE_STORAGE_ACCOUNT and AZURE_STORAGE_KEY which is annoying even with utilities like direnv. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it.

This PR fixes the above and makes it use CLI auth as well.

First time contributing to this repo, please point out everything I might have missed.
The doc PRs will come next.

Allow "storage_account" query parameter in the storage backend URL to use Azure
CLI authentication.

Run go mod tidy.

Fixes pulumi#7251
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 3, 2022

Changelog

[uncommitted] (2022-10-04)

Features

  • [backend] Allows CLI auth for Azure blob storage

@Frassle
Copy link
Member

Frassle commented Oct 3, 2022

bors r+

bors bot added a commit that referenced this pull request Oct 3, 2022
10900: Update gocloud.dev to 0.27.0. r=Frassle a=ekini

# Description

Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication. 

Run go mod tidy.

Fixes #7251

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change

## Summary

The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars `AZURE_STORAGE_ACCOUNT` and `AZURE_STORAGE_KEY` which is annoying even with utilities like `direnv`. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it.

This PR fixes the above and makes it use CLI auth as well.

First time contributing to this repo, please point out everything I might have missed.
The doc PRs will come next.

Co-authored-by: Eugene Dementyev <e@dementyev.me>
@Frassle
Copy link
Member

Frassle commented Oct 3, 2022

Thanks for this!

@bors
Copy link
Contributor

bors bot commented Oct 3, 2022

Build failed:

@Frassle
Copy link
Member

Frassle commented Oct 3, 2022

@AaronFriel looks like issues with the job templates?

@AaronFriel
Copy link
Member

AaronFriel commented Oct 4, 2022

@Frassle this usually indicates we need to run make tidy or there's another issue that would block a build, I tried to make the error more apparent but it's buried in the logs:

  Traceback (most recent call last):
    File "./scripts/get-job-matrix.py", line 611, in <module>
      main()
    File "./scripts/get-job-matrix.py", line 608, in main
      args.func(args)
    File "./scripts/get-job-matrix.py", line 447, in generate_matrix
      matrix = get_matrix(
    File "./scripts/get-job-matrix.py", line 390, in get_matrix
      pkg_tests = run_list_tests(item.package_dir, tags)
    File "./scripts/get-job-matrix.py", line 167, in run_list_tests
      raise Exception(message) from err
  Exception: Failed to list tests in package dir 'tests/integration', usually this implies a Go compilation error. Check that `make lint` succeeds.

@Frassle
Copy link
Member

Frassle commented Oct 4, 2022

bors merge

bors bot added a commit that referenced this pull request Oct 4, 2022
10900: Update gocloud.dev to 0.27.0. r=Frassle a=ekini

# Description

Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication. 

Run go mod tidy.

Fixes #7251

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change

## Summary

The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars `AZURE_STORAGE_ACCOUNT` and `AZURE_STORAGE_KEY` which is annoying even with utilities like `direnv`. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it.

This PR fixes the above and makes it use CLI auth as well.

First time contributing to this repo, please point out everything I might have missed.
The doc PRs will come next.

Co-authored-by: Eugene Dementyev <e@dementyev.me>
Co-authored-by: Fraser Waters <fraser@pulumi.com>
@bors
Copy link
Contributor

bors bot commented Oct 4, 2022

Build failed:

@Frassle
Copy link
Member

Frassle commented Oct 5, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Build succeeded:

  • bors-ok

@bors bors bot merged commit 6934c78 into pulumi:master Oct 5, 2022
@ekini ekini deleted the feature/azureblob_backend_cli_auth branch October 5, 2022 19:19
@Frassle Frassle added the hacktoberfest-accepted PR accepted for hacktoberfest label Oct 5, 2022
ekini added a commit to ekini/pulumi-hugo that referenced this pull request Oct 6, 2022
AaronFriel added a commit to pulumi/pulumi-hugo that referenced this pull request Oct 10, 2022
* Add storage_account parameter to Azure Blob Storage backend

to use cli auth

Related to pulumi/pulumi#10900
Related to google/go-cloud#3159

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
aaronkao pushed a commit to pulumi/pulumi-hugo that referenced this pull request Nov 1, 2022
* Add storage_account parameter to Azure Blob Storage backend

to use cli auth

Related to pulumi/pulumi#10900
Related to google/go-cloud#3159

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a credential-free way of using pulumi with Azure Blob storage as a custom pulumi backend
4 participants