-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gocloud.dev to 0.27.0. #10900
Conversation
Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication. Run go mod tidy. Fixes pulumi#7251
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2022-10-04)Features
|
bors r+ |
10900: Update gocloud.dev to 0.27.0. r=Frassle a=ekini # Description Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication. Run go mod tidy. Fixes #7251 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change ## Summary The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars `AZURE_STORAGE_ACCOUNT` and `AZURE_STORAGE_KEY` which is annoying even with utilities like `direnv`. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it. This PR fixes the above and makes it use CLI auth as well. First time contributing to this repo, please point out everything I might have missed. The doc PRs will come next. Co-authored-by: Eugene Dementyev <e@dementyev.me>
Thanks for this! |
Build failed: |
@AaronFriel looks like issues with the job templates? |
@Frassle this usually indicates we need to run
|
bors merge |
10900: Update gocloud.dev to 0.27.0. r=Frassle a=ekini # Description Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication. Run go mod tidy. Fixes #7251 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change ## Summary The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars `AZURE_STORAGE_ACCOUNT` and `AZURE_STORAGE_KEY` which is annoying even with utilities like `direnv`. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it. This PR fixes the above and makes it use CLI auth as well. First time contributing to this repo, please point out everything I might have missed. The doc PRs will come next. Co-authored-by: Eugene Dementyev <e@dementyev.me> Co-authored-by: Fraser Waters <fraser@pulumi.com>
Build failed: |
bors retry |
Build succeeded:
|
to use cli auth Related to pulumi/pulumi#10900 Related to google/go-cloud#3159
* Add storage_account parameter to Azure Blob Storage backend to use cli auth Related to pulumi/pulumi#10900 Related to google/go-cloud#3159 Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
* Add storage_account parameter to Azure Blob Storage backend to use cli auth Related to pulumi/pulumi#10900 Related to google/go-cloud#3159 Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Description
Allow "storage_account" query parameter in the storage backend URL to use Azure CLI authentication.
Run go mod tidy.
Fixes #7251
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my changeSummary
The feature I've been personally waiting for quite long. Currently if you want to use Azure Blob storage as the backend, you have to set the env vars
AZURE_STORAGE_ACCOUNT
andAZURE_STORAGE_KEY
which is annoying even with utilities likedirenv
. In addition to that, the backend URL set in Pulumi.yaml can't fully define the storage backend as it doesn't have the storage account in it.This PR fixes the above and makes it use CLI auth as well.
First time contributing to this repo, please point out everything I might have missed.
The doc PRs will come next.