show time elapsed per resource in update #10953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-11)Features
|
dixler
force-pushed
the
dixler/10534/time-elapsed
branch
3 times, most recently
from
7abb9c8
to
a331aa5
Compare
dixler
commented
Oct 6, 2022
dixler
force-pushed
the
dixler/10534/time-elapsed
branch
from
a331aa5
to
b1c0d1d
Compare
Frassle
reviewed
Oct 6, 2022
| return "" | ||
| end, ok := display.opStopwatch.end[step.URN] | ||
| if !ok { | ||
| return opText |
There was a problem hiding this comment.
Wander if we should add a bit that the timing information was missing? It shouldn't ever be hit but if it does might prompt people to tell us about it.
There was a problem hiding this comment.
I think silently erroring is fine in this case. It could throw off the progress display to print lines in this codepath or scare the user on a warning too much.
Someone will probably report a bug that a resource's time elapsed isn't showing up when all of the others are showing up.
There was a problem hiding this comment.
Yeh thinking on this more I'd be happier with a rework to make the missing times unrepresentable, but that's a minor thing we can pick up when it's convenient.
|
updated display as per @susanev recommendation |
Frassle
reviewed
Oct 7, 2022
pkg/backend/display/progress.go
Outdated
| if opDuration < 1 { | ||
| // Display a more fine-grain duration as the operation | ||
| // has completed. | ||
| return fmt.Sprintf("%s (%.2f secs)", opText, opDuration) |
Frassle
approved these changes
Oct 7, 2022
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 7, 2022
10953: show time elapsed per resource in update r=dixler a=dixler <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #10534 This PR modifies the display to show the time that a resource takes to update. [](https://asciinema.org/a/XHYWenULkugoY57kStsadcBH8) ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works. <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Kyle Dixler <kyle@pulumi.com>
justinvp
approved these changes
Oct 7, 2022
|
Minor but I obsess over things like this. Instead of “10 secs” should we say “10s”? More standard abbreviation, less real estate, and more consistent with displays elsewhere (including the summary at the end of every update which is alongside this new display so easy to see them at the same time and notice the inconsistency). |
@joeduffy, see #10953 (comment). Kyle already updated the PR to do just that! 😄 |
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 10, 2022
10953: show time elapsed per resource in update r=dixler a=dixler <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #10534 This PR modifies the display to show the time that a resource takes to update. [](https://asciinema.org/a/XHYWenULkugoY57kStsadcBH8) ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works. <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Kyle Dixler <kyle@pulumi.com>
|
Build failed: |
dixler
force-pushed
the
dixler/10534/time-elapsed
branch
from
aac11c8
to
e06d901
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2022
10953: show time elapsed per resource in update r=dixler a=dixler <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #10534 This PR modifies the display to show the time that a resource takes to update. [](https://asciinema.org/a/XHYWenULkugoY57kStsadcBH8) ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works. <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Kyle Dixler <kyle@pulumi.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2022
10953: show time elapsed per resource in update r=dixler a=dixler <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #10534 This PR modifies the display to show the time that a resource takes to update. [](https://asciinema.org/a/XHYWenULkugoY57kStsadcBH8) ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works. <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Kyle Dixler <kyle@pulumi.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
](https://asciinema.org/a/XHYWenULkugoY57kStsadcBH8){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10534
This PR modifies the display to show the time that a resource takes to update.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change