Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Clean up pulumi stack output for non-deployed stacks #11004

Merged
merged 1 commit into from Oct 13, 2022
Merged

cli: Clean up pulumi stack output for non-deployed stacks #11004

merged 1 commit into from Oct 13, 2022

Conversation

AaronFriel
Copy link
Member

@AaronFriel AaronFriel commented Oct 12, 2022 •
edited

Rather than display some potentially confusing output, only show the update time and Pulumi version used to deploy it when those values are present.

Improves code readability by following current variable styling.

On an empty stack, the display now appears as:

$ pulumi stack
Current stack is dev:
    Owner: friel
Current stack resources (0):
    No resources currently in this stack

Instead of:

$ pulumi stack
Current stack is dev:
    Last update time unknown
    Pulumi version: ?
    Owner: friel
Current stack resources (0):
    No resources currently in this stack

@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-10-12)

susanev
susanev approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@susanev susanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@AaronFriel
Copy link
Member Author

bors merge

1 similar comment
@AaronFriel
Copy link
Member Author

bors merge

@AaronFriel
Copy link
Member Author

Assuming the test failure here is a flake - will let bors sort it out.

@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Build succeeded:

@bors bors bot merged commit b4bf3dd into master Oct 13, 2022
@pulumi-bot pulumi-bot deleted the friel/stack-ux branch October 13, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susanev susanev susanev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AaronFriel @pulumi-bot @susanev