New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Abstract out terminal interactions #11201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-11-09) |
Stacks on top of #11200 |
pgavlin
force-pushed
the
pgavlin/abstract-terminal
branch
5 times, most recently
from
November 1, 2022 05:22
20795d6
to
453872a
Compare
Frassle
approved these changes
Nov 1, 2022
pgavlin
force-pushed
the
pgavlin/abstract-terminal
branch
2 times, most recently
from
November 2, 2022 15:14
2e754cb
to
008e45c
Compare
pgavlin
force-pushed
the
pgavlin/abstract-terminal
branch
from
November 8, 2022 23:04
008e45c
to
2c372de
Compare
pgavlin
added
the
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
label
Nov 8, 2022
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 8, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin Replace direct interaction with the terminal with an abstraction. This abstraction is tightly constrained to the capabilities needed for the CLI's display. Using this abstraction allows for straightforward testing of the interactive renderers. 11296: Update YAML to 1.0.2 r=AaronFriel a=AaronFriel Co-authored-by: Pat Gavlin <pat@pulumi.com> Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Build failed (retrying...): |
bors cancel |
Canceled. |
Replace direct interaction with the terminal with an abstraction. This abstraction is tightly constrained to the capabilities needed for the CLI's display. Using this abstraction allows for straightforward testing of the interactive renderers.
pgavlin
force-pushed
the
pgavlin/abstract-terminal
branch
from
November 9, 2022 01:14
2c372de
to
a20ddff
Compare
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin Replace direct interaction with the terminal with an abstraction. This abstraction is tightly constrained to the capabilities needed for the CLI's display. Using this abstraction allows for straightforward testing of the interactive renderers. Co-authored-by: Pat Gavlin <pat@pulumi.com>
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin Replace direct interaction with the terminal with an abstraction. This abstraction is tightly constrained to the capabilities needed for the CLI's display. Using this abstraction allows for straightforward testing of the interactive renderers. Co-authored-by: Pat Gavlin <pat@pulumi.com>
Timed out. |
bors retry |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.