Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Abstract out terminal interactions #11201

Merged
merged 1 commit into from Nov 9, 2022
Merged

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Oct 31, 2022

Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 31, 2022

Changelog

[uncommitted] (2022-11-09)

@pgavlin
Copy link
Member Author

pgavlin commented Oct 31, 2022

Stacks on top of #11200

@pgavlin pgavlin force-pushed the pgavlin/abstract-terminal branch 5 times, most recently from 20795d6 to 453872a Compare November 1, 2022 05:22
@pgavlin pgavlin force-pushed the pgavlin/abstract-terminal branch 2 times, most recently from 2e754cb to 008e45c Compare November 2, 2022 15:14
@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 8, 2022
@pgavlin
Copy link
Member Author

pgavlin commented Nov 8, 2022

bors merge

bors bot added a commit that referenced this pull request Nov 8, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin

Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.

11296: Update YAML to 1.0.2 r=AaronFriel a=AaronFriel



Co-authored-by: Pat Gavlin <pat@pulumi.com>
Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
@bors
Copy link
Contributor

bors bot commented Nov 9, 2022

Build failed (retrying...):

@AaronFriel
Copy link
Member

bors cancel

@bors
Copy link
Contributor

bors bot commented Nov 9, 2022

Canceled.

Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.
@pgavlin
Copy link
Member Author

pgavlin commented Nov 9, 2022

bors merge

bors bot added a commit that referenced this pull request Nov 9, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin

Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.

Co-authored-by: Pat Gavlin <pat@pulumi.com>
bors bot added a commit that referenced this pull request Nov 9, 2022
11201: [cli] Abstract out terminal interactions r=pgavlin a=pgavlin

Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.

Co-authored-by: Pat Gavlin <pat@pulumi.com>
@bors
Copy link
Contributor

bors bot commented Nov 9, 2022

Timed out.

@pgavlin
Copy link
Member Author

pgavlin commented Nov 9, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 9, 2022

Build succeeded:

@bors bors bot merged commit fdb5ea2 into master Nov 9, 2022
@bors bors bot deleted the pgavlin/abstract-terminal branch November 9, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants