[auto/nodejs] Test remote operations #11292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
added
the
impact/no-changelog-required
Changelog[uncommitted] (2022-11-09) |
justinvp
force-pushed
the
justin/remote_tests_nodejs
branch
from
be8522f
to
3eb3b08
Compare
justinvp
commented
Nov 8, 2022
Comment on lines
-158
to
+162
| if (args.commitHash && args.branch) { | ||
| throw new Error("commitHash and branch cannot both be specified."); | ||
| if (args.branch && args.commitHash) { | ||
| throw new Error("branch and commitHash cannot both be specified."); | ||
| } | ||
| if (!args.commitHash && !args.branch) { | ||
| throw new Error("at least commitHash or branch are required."); | ||
| if (!args.branch && !args.commitHash) { | ||
| throw new Error("either branch or commitHash is required."); |
There was a problem hiding this comment.
Minor change to reorder the check to match the error message (changed to be consistent with CLI and other languages).
justinvp
commented
Nov 8, 2022
justinvp
commented
Nov 8, 2022
justinvp
force-pushed
the
justin/remote_tests_nodejs
branch
from
3eb3b08
to
e0179b5
Compare
This was referenced Nov 9, 2022
RobbieMcKinstry
approved these changes
Nov 9, 2022
Also cleans up some error messages to be consistent with the CLI and other languages.
justinvp
force-pushed
the
justin/remote_tests_nodejs
branch
from
e0179b5
to
31bf640
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
11292: [auto/nodejs] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - #11290 - #11291 - #11293 - #11294 11293: [auto/python] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - #11290 - #11291 - #11292 - #11294 Co-authored-by: Justin Van Patten <jvp@justinvp.com>
|
Build failed (retrying...): |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
11290: [cli] Test remote operations r=justinvp a=justinvp Also some changes to validate flags earlier (before getting the backend). Related: - #11291 - #11292 - #11293 - #11294 11293: [auto/python] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - #11290 - #11291 - #11292 - #11294 Co-authored-by: Justin Van Patten <jvp@justinvp.com>
bors bot
added a commit
that referenced
this pull request
Nov 24, 2022
11291: [auto/go] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - #11290 - #11292 - #11293 - #11294 11294: [auto/dotnet] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - #11290 - #11291 - #11292 - #11293 Co-authored-by: Justin Van Patten <jvp@justinvp.com>
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
11291: [auto/go] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - pulumi/pulumi#11290 - pulumi/pulumi#11292 - pulumi/pulumi#11293 - pulumi/pulumi#11294 11294: [auto/dotnet] Test remote operations r=justinvp a=justinvp Also cleans up some error messages to be consistent with the CLI and other languages. Related: - pulumi/pulumi#11290 - pulumi/pulumi#11291 - pulumi/pulumi#11292 - pulumi/pulumi#11293 Co-authored-by: Justin Van Patten <jvp@justinvp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up some error messages to be consistent with the CLI and other languages.
Related: