-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CI badges, move EOL below langs #11377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieMcKinstry
added
area/docs
Improvements or additions to documentation
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
labels
Nov 16, 2022
Changelog[uncommitted] (2022-11-16) |
Frassle
approved these changes
Nov 16, 2022
AaronFriel
approved these changes
Nov 16, 2022
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2022
11377: Remove CI badges, move EOL below langs r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description Because `master` is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information since `master` is always green. <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11280 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
Build failed: |
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2022
11377: Remove CI badges, move EOL below langs r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description Because `master` is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information since `master` is always green. <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11280 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
Build failed: |
bors retry |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docs
Improvements or additions to documentation
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because
master
is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information sincemaster
is always green.Fixes #11280
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my change