Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI badges, move EOL below langs #11377

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Remove CI badges, move EOL below langs #11377

merged 1 commit into from
Nov 17, 2022

Conversation

RobbieMcKinstry
Copy link
Contributor

Description

Because master is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information since master is always green.

Fixes #11280

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@RobbieMcKinstry RobbieMcKinstry added area/docs Improvements or additions to documentation impact/no-changelog-required This issue doesn't require a CHANGELOG update labels Nov 16, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-16)

@RobbieMcKinstry
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2022
11377: Remove CI badges, move EOL below langs r=RobbieMcKinstry a=RobbieMcKinstry

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

Because `master` is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information since `master` is always green.

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #11280 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Build failed:

@RobbieMcKinstry
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Nov 16, 2022
11377: Remove CI badges, move EOL below langs r=RobbieMcKinstry a=RobbieMcKinstry

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

Because `master` is always green by tautologically, this PR removes the CI badges from the repo. The Linux badge was broken, and there's no way to reconstitute it with our new setup. Further, it wouldn't provide any meaningful information since `master` is always green.

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #11280 

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

Build failed:

@RobbieMcKinstry
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

Build succeeded:

@bors bors bot merged commit 982656f into master Nov 17, 2022
@pulumi-bot pulumi-bot deleted the mckinstry/#11280 branch November 17, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Linux X64 Build Status badge is not showing
4 participants