Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack selection behavior #11408

merged 1 commit into from Nov 18, 2022

Fix stack selection behavior #11408

merged 1 commit into from Nov 18, 2022


Copy link

@aq17 aq17 commented Nov 18, 2022


Fixes #11407
Follow on to PR 11354. When we don't prompt to create a new stack, we should default to an existing stack so the empty string isn't populated.


  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@aq17 aq17 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 18, 2022
Copy link


[uncommitted] (2022-11-18)

Copy link

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but other than that LGTM.

pkg/cmd/pulumi/util.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

aq17 commented Nov 18, 2022

bors r+

Copy link

bors bot commented Nov 18, 2022

Build succeeded:

@bors bors bot merged commit a02ca0c into master Nov 18, 2022
@bors bors bot deleted the aqiu/11407 branch November 18, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
impact/no-changelog-required This issue doesn't require a CHANGELOG update
None yet

Successfully merging this pull request may close these issues.

Pulumi delete not working as expected in version v3.47.0
3 participants