Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge #10831" #11534

Merged
merged 1 commit into from Dec 5, 2022
Merged

Revert "Merge #10831" #11534

merged 1 commit into from Dec 5, 2022

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Dec 5, 2022

This reverts commit 184903a, reversing changes made to 356d8eb.

Fixes #11531 (see comments for further context)

@aq17
Revert "Merge #10831"
20e5b33 
This reverts commit 184903a, reversing
changes made to 356d8eb.
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-12-05)

@aq17 aq17 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 5, 2022
@aq17 aq17 requested a review from t0yv0 December 5, 2022 18:24
@aq17
Copy link
Contributor Author

aq17 commented Dec 5, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 5, 2022

Build succeeded:

@bors bors bot merged commit 86e7d56 into master Dec 5, 2022
@bors bors bot deleted the aqiu/11531 branch December 5, 2022 19:27
@iwahbe
Copy link
Member

iwahbe commented Dec 5, 2022

@RobbieMcKinstry Is there a plan/issue for restoring the functionality reverted?

@RobbieMcKinstry RobbieMcKinstry mentioned this pull request Dec 6, 2022
Open
6 tasks
@RobbieMcKinstry
Copy link
Contributor

RobbieMcKinstry commented Dec 6, 2022 •
edited

@iwahbe yes! :D The work for un-reverting is here, but the broader set of blockers is here.

In a moment I will delineate which of those are blockers for this feature and which are "nice to haves".
Update: done.

RobbieMcKinstry added a commit that referenced this pull request Dec 7, 2022
@RobbieMcKinstry
Reintroduce type splitting in NodeJS codegen.
40abc84 
This commit reintroduces the changes that were reverted
in #11534. This time,
we hide the feature behind language-specific config in the schema,
and default it to off.

At this time, providers should not enable the feature until
#11560 has been addressed.
RobbieMcKinstry added a commit that referenced this pull request Dec 7, 2022
@RobbieMcKinstry
Reintroduce type splitting in NodeJS codegen.
ecf6f78 
This commit reintroduces the changes that were reverted
in #11534. This time,
we hide the feature behind language-specific config in the schema,
and default it to off.

At this time, providers should not enable the feature until
#11560 has been addressed.
@RobbieMcKinstry RobbieMcKinstry mentioned this pull request Dec 7, 2022
Draft
3 tasks
@RobbieMcKinstry RobbieMcKinstry mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieMcKinstry RobbieMcKinstry RobbieMcKinstry approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js split types generated code is not usable
4 participants
@aq17 @pulumi-bot @iwahbe @RobbieMcKinstry