Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure on Windows #11647

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Fix test failure on Windows #11647

merged 1 commit into from
Dec 14, 2022

Conversation

AaronFriel
Copy link
Member

@AaronFriel AaronFriel commented Dec 14, 2022 •
edited
Loading

PR #11611 assumed a unix-y error message in one of the failure cases of the test TestGoModEdits. This case did not match on Windows:

=== FAIL: testing/integration TestGoModEdits/invalid-path-non-existent (0.00s)
    program_test.go:170: 
        	Error Trace:	C:\a\pulumi\pulumi\pkg\testing\integration\program_test.go:170
        	Error:      	Error "error reading go.mod at ../../../.tmp.non-existent-dir: open ..\\..\\..\\.tmp.non-existent-dir\\go.mod: The system cannot find the path specified." does not contain "open ../../../.tmp.non-existent-dir/go.mod: no such file or directory"
        	Test:       	TestGoModEdits/invalid-path-non-existent
    --- FAIL: TestGoModEdits/invalid-path-non-existent (0.00s)

@AaronFriel AaronFriel added the ci/test Test CI pipelines on this PR label Dec 14, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-12-14)

@AaronFriel AaronFriel added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Dec 14, 2022
iwahbe
iwahbe approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the old test get into master? Is the test normally skipped on windows?

@Frassle
Copy link
Member

Frassle commented Dec 14, 2022

Is the test normally skipped on windows?

Windows test failures don't block merge: https://github.com/pulumi/pulumi/pull/11471/files

@AaronFriel
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Build succeeded:

@bors bors bot merged commit 8922b44 into master Dec 14, 2022
@bors bors bot deleted the friel/11611-follow-up branch December 14, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

@Frassle Frassle Awaiting requested review from Frassle

Assignees
No one assigned
Labels
ci/test Test CI pipelines on this PR impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AaronFriel @pulumi-bot @Frassle @iwahbe