update package details anchors #11893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test test test test test test test test test
Changelog[uncommitted] (2023-01-17) |
sean1588
added
the
impact/no-changelog-required
RobbieMcKinstry
approved these changes
Jan 19, 2023
|
haha yeah most of the diff is the newly generated test data. thanks @RobbieMcKinstry |
|
bors try |
|
bors r+ |
tryBuild failed: |
|
Build succeeded: |
abhinav
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Feb 13, 2023
These were added recently in pulumi/pulumi#11996 and pulumi/pulumi#11893. pulumi-java does not yet pass these tests.
abhinav
pushed a commit
to pulumi/pulumi-java
that referenced
this pull request
Feb 13, 2023
Bumps [github.com/pulumi/pulumi/pkg/v3](https://github.com/pulumi/pulumi) from 3.49.0 to 3.54.0. To account for changes since 3.49: - Skips two more codegen tests. These were added recently (pulumi/pulumi#11996 and pulumi/pulumi#11893) and the Java SDK does not pass these yet. - Update generated code—a function without a result doesn't get a Result type anymore (pulumi/pulumi#11596).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: pulumi/registry#1819
OK taking this for round 2. The first PR to make this change I ended up reverting because there were some pages (the function pages and module pages) still being generated with empty href tags.
I have addressed this and updated the change to define the DisplayName and RepositoryName props on the
packageDetailsstruct for the individual module pages and function pages. This updates the repository anchor in the Package Details section of the api docs pages. I updated it to display<package name> repositoryfor the anchor text in place of the url that was previously shown there.So now this will show the following on the following pages: