Test and fix for nodejs automation api #11943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-01-23)Bug Fixes
|
Frassle
force-pushed
the
fraser/configError
branch
from
9ae15f5
to
f6354e6
Compare
Frassle
changed the title
justinvp
approved these changes
Jan 22, 2023
sdk/nodejs/tests/automation/data/testproj_dotnet/ConfigBasic.csproj
Outdated
Show resolved
Hide resolved
Frassle
force-pushed
the
fraser/configError
branch
from
8cccc8d
to
1322e6a
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 23, 2023
11943: Test and fix for nodejs automation api r=Frassle a=Frassle nodejs automation api was setting the envvar PULUMI_CONFIG for every pulumi command it called, this tripped up the dotnet sdk which only expects PULUMI_CONFIG to be set to a valid JSON string (not the empty string). Looks like this was just a slightly confused bit of code to try and deal with parallel programs, I've moved it out of the workspace part of automation api and fixed up the inline server to deal with parallel programs correctly instead. Fixes #11945 Co-authored-by: Fraser Waters <fraser@pulumi.com>
Frassle
force-pushed
the
fraser/configError
branch
from
1322e6a
to
0251f73
Compare
|
Canceled. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs automation api was setting the envvar PULUMI_CONFIG for every pulumi command it called, this tripped up the dotnet sdk which only expects PULUMI_CONFIG to be set to a valid JSON string (not the empty string).
Looks like this was just a slightly confused bit of code to try and deal with parallel programs, I've moved it out of the workspace part of automation api and fixed up the inline server to deal with parallel programs correctly instead.
Fixes #11945