Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[go/sdk] Delegate alias computation to the engine" #11997

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Revert "[go/sdk] Delegate alias computation to the engine" #11997

merged 1 commit into from
Jan 26, 2023

Conversation

Zaid-Ajaj
Copy link
Contributor

Reverts #11935 because we removed the correct fallback behaviour of collapseAliases

@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2023-01-26)

abhinav
abhinav approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

but also, glad we caught this before release

@Zaid-Ajaj
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Build succeeded:

@bors bors bot merged commit 7bcc9e8 into master Jan 26, 2023
@bors bors bot deleted the revert-11935-zaid/go-alias-including-root-stack branch January 26, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinav abhinav abhinav approved these changes

@Frassle Frassle Awaiting requested review from Frassle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zaid-Ajaj @pulumi-bot @abhinav