Use ContinuationToken #1220
Merged
Use ContinuationToken #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL. I refactored the parameter name and client method to remove references to |
|
I'll submit this change after https://github.com/pulumi/pulumi-service/pull/1177 is in staging. Without that PR in the service, CLI integration tests will fail with the new logic as they expect a nil |
lindydonna
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
ContinuationTokenfield when using the service API for fetching an update's logs. This address a potential problem when the update has moved to a terminal state, but not all results were fetched because of paging.See https://github.com/pulumi/pulumi-service/pull/1177#discussion_r181870297.