Add a pulumi cancel command.
#1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command cancels a stack's currently running update, if any. It can be used to recover from the scenario in which an update is aborted without marking the running update as complete. Once an update has been cancelled, it is likely that the affected stack will need to be repaired via an pair of export/import commands before future updates can succeed. This is part of #1077.
joeduffy
approved these changes
Apr 19, 2018
cmd/cancel.go
Outdated
| Use: "cancel [<stack-name>]", | ||
| Args: cmdutil.MaximumNArgs(1), | ||
| Short: "Cancel a stack's currently running update, if any", | ||
| Long: "Cancel a stack's currently running, if any \n" + |
There was a problem hiding this comment.
Super duper nit pick; usually the first line of long ends with punctuation. (Extra space in here too.)
There was a problem hiding this comment.
We should audit the other commands as well; I pulled this style from https://github.com/pulumi/pulumi/blob/master/cmd/stack_rm.go#L26
|
|
||
| // Ensure that we are targeting the Pulumi cloud. | ||
| backend, ok := s.Backend().(cloud.Backend) | ||
| if !ok { |
There was a problem hiding this comment.
Just for my own understanding, will cancel also work for PPCs? If not, should we also be checking RunLocally?
There was a problem hiding this comment.
It will not work for PPCs: the service will issue a 400.
There was a problem hiding this comment.
(which we will then render to the user with its message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command cancels a stack's currently running update, if any. It can
be used to recover from the scenario in which an update is aborted
without marking the running update as complete. Once an update has been
cancelled, it is likely that the affected stack will need to be repaired
via an pair of export/import commands before future updates can succeed.
This is part of #1077.