Fix require reading JSON files #12302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/nodeJsonSlurp
branch
from
d2cec03
to
1ed5454
Compare
Changelog[uncommitted] (2023-02-28)Bug Fixes
|
Frassle
force-pushed
the
fraser/nodeJsonSlurp
branch
from
1ed5454
to
3ba60df
Compare
Frassle
force-pushed
the
fraser/nodeJsonSlurp
branch
from
3ba60df
to
48ec2c6
Compare
abhinav
approved these changes
Mar 1, 2023
Comment on lines
+1329
to
+1330
| assert.Contains(t, stack.Outputs, "bar") | ||
| assert.Equal(t, 3.0, stack.Outputs["bar"].(float64)) |
There was a problem hiding this comment.
optional: we can collapse this into a single equals check:
Suggested change
| assert.Contains(t, stack.Outputs, "bar") | |
| assert.Equal(t, 3.0, stack.Outputs["bar"].(float64)) | |
| assert.Equal(t, map[string]any{"bar": float64(3)}, stack.Outputs) |
|
bors merge |
|
Build succeeded: |
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2023
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description This PR fixes a small problem with ProgramTest, that the `With` function doesn't propagate the `PostPrepareProject` option as it should. e.g. ```go options := baseOptions.With(integration.ProgramTestOptions{ PostPrepareProject: func(p *engine.Projinfo) error { // ... }, }) ``` A follow-up to: #12302 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12301
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change