codegen/{go,js,.net,py}: Generate retainOnDelete #12306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Changelog[uncommitted] (2023-03-06)Features
|
abhinav
force-pushed
the
abhinav/gen-retain-on-delete
branch
from
707ae8f
to
f0a76d5
Compare
abhinav
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Feb 28, 2023
Temporarily pins to the branch for pulumi/pulumi#12306 so that we can wire up the codegen changes.
It most certainly does. I don't know where this is getting the .NET SDK, but it might just be a super old version. |
abhinav
force-pushed
the
abhinav/gen-retain-on-delete
branch
from
f0a76d5
to
4bac333
Compare
abhinav
force-pushed
the
abhinav/pcl-retain-on-delete
branch
from
5ede5bd
to
a3a8172
Compare
abhinav
force-pushed
the
abhinav/gen-retain-on-delete
branch
from
4bac333
to
50372c4
Compare
Yup it's linking to Pulumi.Random 4.2.0 which is from like 2021. |
abhinav
added a commit
that referenced
this pull request
Mar 1, 2023
Adds the most recent relese of pulumi-random to included schemas. We need something newer than 4.2.0 or 4.3.1 (both from 2021) to test options added since then, like retainOnDelete. Refs #12306 (comment)
abhinav
added a commit
that referenced
this pull request
Mar 3, 2023
Adds the most recent relese of pulumi-random to included schemas. We need something newer than 4.2.0 or 4.3.1 (both from 2021) to test options added since then, like retainOnDelete. Refs #12306 (comment)
bors bot
added a commit
that referenced
this pull request
Mar 3, 2023
12326: testdata/schema: Add random 4.11.2 r=abhinav a=abhinav Adds the most recent relese of pulumi-random to included schemas. We need something newer than 4.2.0 or 4.3.1 (both from 2021) to test options added since then, like retainOnDelete. Refs #12306 (comment) Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
abhinav
force-pushed
the
abhinav/pcl-retain-on-delete
branch
from
a3a8172
to
7d1a9ec
Compare
abhinav
force-pushed
the
abhinav/gen-retain-on-delete
branch
from
50372c4
to
95f76c0
Compare
Thanks! Fixed in #12326. |
Uses the newly added `options.retainOnDelete` in PCL to generate the RetainOnDelete resource option for Go, NodeJS, .NET, and Python. Java support cannot be added without a release of pulumi/pulumi because the new field in pcl.ResourceOptions is not yet visible to Java. Resolves #12304
abhinav
force-pushed
the
abhinav/gen-retain-on-delete
branch
from
95f76c0
to
407e695
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the newly added
options.retainOnDeletein PCLto generate the RetainOnDelete resource option
for Go, NodeJS, .NET, and Python.
Java support cannot be added without a release of pulumi/pulumi
because the new field in pcl.ResourceOptions is not yet visible
to Java.
The change has been staged at pulumi/pulumi-java#1005
pending merge and release of #12305.
Resolves #12304