Remove the global caches for project files #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-03-07)Bug Fixes
|
Frassle
force-pushed
the
fraser/removeFileCaches
branch
from
f737f03
to
d302359
Compare
Frassle
force-pushed
the
fraser/removeFileCaches
branch
from
d302359
to
e6e7b5e
Compare
|
Simple is smooth, smooth is fast :-) |
Frassle
commented
Mar 7, 2023
|
|
||
| reloaded, err := s.workspace.StackSettings(ctx, stackName) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, stackConfig, reloaded) |
There was a problem hiding this comment.
Amusingly because of the old caching logic this just asserted that X=X
abhinav
approved these changes
Mar 8, 2023
Comment on lines
-29
to
-31
| var projectSingleton = &projectLoader{ | ||
| internal: map[string]*Project{}, | ||
| } |
|
Merging per @Frassle's request. |
|
bors merge |
|
Build succeeded: |
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Mar 9, 2023
Other than being the most recent, this picks up the change made in
pulumi/pulumi#12370
which removes caching of project and stack files, which fixes #411.
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Mar 9, 2023
Other than being the most recent, this picks up the change made in
pulumi/pulumi#12370
which removes caching of project and stack files, which fixes #411.
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
added a commit
to pulumi/pulumi-kubernetes-operator
that referenced
this pull request
Mar 9, 2023
* Update Pulumi SDK and base image to v3.57.1
Other than being the most recent, this picks up the change made in
pulumi/pulumi#12370
which removes caching of project and stack files, which fixes #411.
* Add entry for #422 to changelog
---------
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12152
This caching was originally added in #6576 two years ago. It saved a lot of file access because the system was repeatedly calling into the workspace module to load and re-load project files. We've cleaned up the system code to instead load the project files once, and pass the loaded
workspace.Projectobject down the callchain to other sites that need it, rather than each site searching and loading the project. As such removing these caches shouldn't regress performance.Checklist
make changelogand committed thechangelog/pending/<file>documenting my change