Don't send empty token/Bearer headers #12392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-03-09)Bug Fixes
|
Zaid-Ajaj
approved these changes
Mar 9, 2023
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12391
This looks to be the cause of the 401 responses from GitHub. When we refactored some code to add GitLab authorization headers we started sending half-filled headers when the envvars weren't set (e.g. Authorization = "token "). Looks like this was triggering GitHub to just blanket fail these requests to the /releases endpoint even though authorization wasn't even needed.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change