Escape import names for python

changelog/pending/20230316--programgen-python--fix-handling-of-reserved-words-in-imports.yaml

@@ -0,0 +1,4 @@
+changes:
+- type: fix
+  scope: programgen/python
+  description: Fix handling of reserved words in imports.

pkg/codegen/python/gen_program.go

@@ -256,7 +256,7 @@ func (g *generator) genPreamble(w io.Writer, program *pcl.Program, preambleHelpe
 		}
 		control := importSet[pkg]
 		if control.ImportAs {
-			imports = append(imports, fmt.Sprintf("import %s as %s", pkg, control.Pkg))
+			imports = append(imports, fmt.Sprintf("import %s as %s", pkg, EnsureKeywordSafe(control.Pkg)))
 		} else {
 			imports = append(imports, fmt.Sprintf("import %s", pkg))
 		}

pkg/codegen/testing/test/program_driver.go

@@ -245,6 +245,11 @@ var PulumiPulumiProgramTests = []ProgramTest{
 		Directory:   "throw-not-implemented",
 		Description: "Function notImplemented is compiled to a runtime error at call-site",
 	},
+	{
+		Directory:   "python-reserved",
+		Description: "Test python reserved words aren't used",
+		Skip:        allProgLanguages.Except("python"),
+	},
 }
 
 var PulumiPulumiYAMLProgramTests = []ProgramTest{

pkg/codegen/testing/test/testdata/lambda-0.1.0.json

@@ -0,0 +1,21 @@
+{
+  "$schema": "https://raw.githubusercontent.com/pulumi/pulumi/master/pkg/codegen/schema/pulumi.json",
+  "name": "lambda",
+  "version": "0.1.0",
+  "//": "Test schema for checking python codegen when packages, modules and types have reserved names.",
+  "resources": {
+    "lambda:lambda:Lambda": {
+      "properties": {
+        "lambda": {
+          "type": "string"
+        }
+      },
+      "inputProperties": {
+        "lambda": {
+          "type": "string"
+        }
+      },
+      "type": "object"
+    }
+  }
+}

pkg/codegen/testing/test/testdata/python-reserved-pp/python-reserved.pp

@@ -0,0 +1,7 @@
+resource assert "lambda:lambda:Lambda" {
+    lambda = "dns"
+}
+
+output global {
+    value = assert.lambda
+}

pkg/codegen/testing/test/testdata/python-reserved-pp/python/python-reserved.py

@@ -0,0 +1,5 @@
+import pulumi
+import pulumi_lambda as lambda_
+
+assert_ = lambda_.lambda_.Lambda("assert", lambda_="dns")
+pulumi.export("global", assert_.lambda_)

pkg/codegen/testing/utils/host.go

@@ -79,5 +79,6 @@ func NewHost(schemaDirectoryPath string) plugin.Host {
 
 		SchemaProvider{"other", "0.1.0"},
 		SchemaProvider{"synthetic", "1.0.0"},
+		SchemaProvider{"lambda", "0.1.0"},
 	)
 }