pkg/backend: Delete SupportsTeams methods #12551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deletes the SupportsTeams method added in #11974. It came up during review that we want to avoid too many new "SupportsFoo" methods. Instead, we'll let each backend report whether it supports teams by returning ErrTeamsNotSupported. As a result of this change, validateCreateStackOpts cannot error, so it's been renamed to newCreateStackOptions. Testing: There's already a test (added in the #12499 refactor) that verifies that we report the appropriate error when the backend doesn't support --teams. This updates the mock in that test.
Deletes the teamsUnsupportedError type. We're not matching on this anywhere, there are no independent tests for just the error type, and the error message itself is really short. This can all be replaced with a `fmt.Errorf`.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
abhinav
added
the
impact/no-changelog-required
Changelog[uncommitted] (2023-03-29) |
Frassle
approved these changes
Mar 30, 2023
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the SupportsTeams method added in #11974.
It came up during review that we want to avoid too many new
"SupportsFoo" methods.
Instead, we'll let each backend report whether it supports teams
by returning ErrTeamsNotSupported.
As a result of this change, validateCreateStackOpts cannot error,
so it's been renamed to newCreateStackOptions.
Testing:
There's already a test (added in the #12499 refactor)
that verifies that we report the appropriate error
when the backend doesn't support --teams.
This updates the mock in that test.