Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support map(any) in config/output types #12619

Merged
merged 1 commit into from Apr 7, 2023
Merged

Support map(any) in config/output types #12619

merged 1 commit into from Apr 7, 2023

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Apr 6, 2023 •
edited

Description

Encountered while doing terraform conversions, the current binder couldn't handle types like map(any).

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested a review from Zaid-Ajaj April 6, 2023 20:16
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2023-04-06)

Bug Fixes

  • [programgen] Suppport the any type in config and outputs.
    #12619

RobbieMcKinstry
RobbieMcKinstry approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@RobbieMcKinstry RobbieMcKinstry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frassle
Copy link
Member Author

Frassle commented Apr 7, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 7, 2023

Build succeeded:

  • bors-ok

@bors bors bot merged commit 9e7c312 into master Apr 7, 2023
44 of 48 checks passed
@bors bors bot deleted the fraser/anyType branch April 7, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieMcKinstry RobbieMcKinstry RobbieMcKinstry approved these changes

@Zaid-Ajaj Zaid-Ajaj Awaiting requested review from Zaid-Ajaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frassle @pulumi-bot @RobbieMcKinstry