[pcl] Do not panic when the type of PCL local variable isn't known #12670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2023-04-13)Miscellaneous
|
Frassle
approved these changes
Apr 13, 2023
| @@ -36,6 +36,9 @@ func (lv *LocalVariable) SyntaxNode() hclsyntax.Node { | |||
| } | |||
|
|
|||
| func (lv *LocalVariable) Traverse(traverser hcl.Traverser) (model.Traversable, hcl.Diagnostics) { | |||
| if lv == nil || lv.Type() == nil { | |||
There was a problem hiding this comment.
I'm not sure tbh, though I don't think so 🤔
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 14, 2023
12670: [pcl] Do not panic when the type of PCL local variable isn't known r=Zaid-Ajaj a=Zaid-Ajaj Another small fix for PCL binding so that we don't panic when the type of a local variable isn't known. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 12674: Improve plugin install help text r=Zaid-Ajaj a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> `@EvanBoyle` commented that it wasn't that clear that VERSION was optional in this command. ``` Install one or more plugins. This command is used manually install plugins required by your program. It may be run either with a specific KIND, NAME, and optionally VERSION, or by omitting these and letting Pulumi compute the set of plugins that may be required by the current project. If specified VERSION cannot be a range: it must be a specific number. If not specified pulumi will try to look up the latest version of the plugin, this is not always possible. If you let Pulumi compute the set to download, it is conservative and may end up downloading more plugins than is strictly necessary. Usage: pulumi plugin install [KIND NAME [VERSION]] [flags] ``` Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com> Co-authored-by: Fraser Waters <fraser@pulumi.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Apr 14, 2023
12670: [pcl] Do not panic when the type of PCL local variable isn't known r=Zaid-Ajaj a=Zaid-Ajaj Another small fix for PCL binding so that we don't panic when the type of a local variable isn't known. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small fix for PCL binding so that we don't panic when the type of a local variable isn't known.
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change