[typescript/program-gen] Allow iterating dynamic entries in TypeScript

[Zaid-Ajaj]

This PR fixes an issue in TypeScript program-gen to allow iterating over a dynamic variable. Treats them the same way maps and objects are handled.

This piece of code:

  validationOptions = [for entry in entries(validationOption) : {
    domainName       = entry.value["domain_name"]
    validationDomain = entry.value["validation_domain"]
  }]

used to compile to

// invalid TypeScript
validationOptions:  => ({key: k, value: v})).map(entry => ({
        domainName: entry.value.domain_name,
        validationDomain: entry.value.validation_domain,
    })),

but now fixed to compile to

validationOptions: Object.entries(validationOption).map(([k, v]) => ({key: k, value: v})).map(entry => ({
        domainName: entry.value.domain_name,
        validationDomain: entry.value.validation_domain,
    })),

See added test example for full code.

Checklist

• I have added tests that prove my fix is effective or that my feature works

• I have run make changelog and committed the changelog/pending/<file> documenting my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

[pulumi-bot]

Changelog

[uncommitted] (2023-05-16)

Bug Fixes

• [programgen/nodejs] Allow iterating dynamic entries in TypeScript
  #12961

[Zaid-Ajaj]

@justinvp for some reason, compiling the generated TypeScript program seems to fail. I've confirmed that the generated code compiles and type-checks just fine from a fresh pulumi new typescript program 🤔 I'll skip the compilation for now and merge if all is green.

[Zaid-Ajaj]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• bors-ok