Invoke node directly from the language host #1300
Conversation
Instead of using a shell script to jump from the language host into
node, just invoke node directly. This makes our start-up path a little
simpler to understand and indirectly fixes pulumi/home#156, where we
would fail on Windows if the `-exec` script was in a folder that had
spaces in it (due to a subtle interaction between how go launches cmd
files and how cmd.exe parses arguments).
|
@swgillespie Can you tell me what you think of this approach? I'm biased towards removing the shell scripts because they make the process of actually launching the language even harder to follow (and causes issues on windows because of how we have to invoke cmd). |
|
@ellismg 👍 to the approach! Definitely easier to follow what's going on without the bash and cmd. I've got a headache at the moment so I'll look at the code in more detail in a little bit. |
| <Exec Command="aws s3 cp s3://eng.pulumi.com/nativeruntime/windows/nativeruntime.node $(NodeJSSdkDirectory)\prebuilt\nativeruntime.node" /> | ||
| <Exec Command="aws s3 cp s3://eng.pulumi.com/nativeruntime/windows/nativeruntime-v0.11.0.node $(NodeJSSdkDirectory)\prebuilt\nativeruntime-v0.11.0.node" /> | ||
| <Exec Command="aws s3 cp s3://eng.pulumi.com/nativeruntime/windows/pulumi-language-nodejs-node.exe $(NodeJSSdkDirectory)\prebuilt\pulumi-language-nodejs-node.exe" /> | ||
| <Exec Command="aws s3 cp s3://eng.pulumi.com/nativeruntime/windows/nativeruntime.node "$(NodeJSSdkDirectory)\prebuilt\nativeruntime.node"" /> |
There was a problem hiding this comment.
The addition of " sorts of changes are to deal with the self inflected pain I face by having my user name on windows have a space in it, so my GOPATH ends up with a space in it as well.
| nodeExecSuffix = "-exec" // the exec shim for Pulumi to run Node programs. | ||
| // The path to the "run" program which will spawn the rest of the language host. This may be overriden with | ||
| // PULUMI_LANGUAGE_NODEJS_RUN_PATH, which we do in some testing cases. | ||
| defaultRunPath = "./node_modules/@pulumi/pulumi/cmd/run" |
There was a problem hiding this comment.
Do we need to worry about path separator differences? Not sure if Go can handle that gracefully or not.
There was a problem hiding this comment.
Node ends up handling this without issue. It was even okay with NODE_PATH having a mix of / and \ path separators (I validated that require('nativeruntime') worked, on windows, even when there was a space in the path and it had mixed separators)
lindydonna
added
impact/changelog
kind/bug
Instead of using a shell script to jump from the language host into
node, just invoke node directly. This makes our start-up path a little
simpler to understand and indirectly fixes pulumi/home#156, where we
would fail on Windows if the
-execscript was in a folder that hadspaces in it (due to a subtle interaction between how go launches cmd
files and how cmd.exe parses arguments).