Fix version number in typerefs when marshalling schemas

[Frassle]

Description

Fixes #13000

Checklist

• I have added tests that prove my fix is effective or that my feature works

• I have run make changelog and committed the changelog/pending/<file> documenting my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

[pulumi-bot]

Changelog

[uncommitted] (2023-05-24)

Bug Fixes

• [sdkgen/go] Fix versioned typerefs being marshalled across code generator RPCs.
  #13006

[abhinav]

Is this something we can add a unit test for?

[RobbieMcKinstry]

Do we need a guard in case the string already starts with v? i.e. check if the semver string is normalized to include the v, and if not, add the v ourselves. Or is that over-complicating things?

[Frassle]

Do we need a guard in case the string already starts with v? i.e. check if the semver string is normalized to include the v, and if not, add the v ourselves. Or is that over-complicating things?

We don't. container.Version is a semver.Version which doesn't include a 'v' in it's String() result.

Is this something we can add a unit test for?

I'll have a look, although stuff like this should get covered by matrix testing as that comes online anyway.

[Frassle]

bors merge

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• bors-ok

[mikhailshilkov]

@Frassle I want to ask you to provide descriptions for your PRs. The fact that it fixes #13000 isn't enough for me to get the context. I want to read

• Description of a problem
• What happened why the problem occurred
• What the fix is
• How we test it

Thank you!