Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test TestCreatingStackWithNumericName #13253

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

dixler
Copy link
Contributor

@dixler dixler commented Jun 22, 2023

TestCreatingStackWithNumericName is failing due to using a constant project name. A failed test run may leave a project behind so we now use a unix timestamp to try to guarantee uniqueness.

@dixler dixler added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 22, 2023
@dixler dixler requested a review from abhinav June 22, 2023 21:24
@dixler dixler marked this pull request as ready for review June 22, 2023 21:24
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2023-06-22)

`TestCreatingStackWithNumericName` is failing due to using a constant
project name. A failed test run may leave a project behind so we now use
a unix timestamp to try to guarantee uniqueness.
@dixler dixler requested a review from justinvp June 22, 2023 21:27
@dixler
Copy link
Contributor Author

dixler commented Jun 22, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 22, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 5203472 into master Jun 22, 2023
42 checks passed
@bors bors bot deleted the dixler/fix-test branch June 22, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants